From patchwork Thu Jan 11 16:27:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13517618 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B5AF4F89C; Thu, 11 Jan 2024 16:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hvYf1RF6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24BD9C433F1; Thu, 11 Jan 2024 16:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704990519; bh=wOlw6k8oeC5WKfVf/WyGf04YxAUDhKpIuRBaG8SWzXg=; h=From:To:Cc:Subject:Date:From; b=hvYf1RF6DuM/eVkHhjtTnrm4XHlLDo7AH1VNzHShDw1mFxJhgPvSmSoODMm2I3D75 Dxh0yBW7wvX9tr5/wPuDviqS9VfriM8H+JjVDIVsoq4J0ypKM+KgzhSCS4KTfZh972 WeFKbC8kWdlzezOM4M3gAgvP/KtoCKDhUlijhfmientVwgiBHTDKuKtLyBP1LdXKr8 KtGRgGaGIkOrYch0RL7PC3sWIVrdkAIbs/6++VdxZtixlW8G9WIHB5zdSQHVnieGyE iBRNA/w8hR2ZGny1QGQCsF8KYUsisgjyrMqkkO0vdkG1KMOP5857vaZVKGKo0Uv2Ot DcE/6Heg1ZCVg== From: Arnd Bergmann To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Arnd Bergmann , Jiawen Wu , Mengyuan Lou , Russell King , Andrew Lunn , Maciej Fijalkowski , Andy Shevchenko , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [net-next v2] wangxunx: select CONFIG_PHYLINK where needed Date: Thu, 11 Jan 2024 17:27:53 +0100 Message-Id: <20240111162828.68564-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Arnd Bergmann The ngbe driver needs phylink: arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset': wx_ethtool.c:(.text+0x458): undefined reference to `phylink_ethtool_nway_reset' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_remove': ngbe_main.c:(.text+0x7c): undefined reference to `phylink_destroy' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_open': ngbe_main.c:(.text+0xf90): undefined reference to `phylink_connect_phy' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.o: in function `ngbe_mdio_init': ngbe_mdio.c:(.text+0x314): undefined reference to `phylink_create' Add the missing Kconfig description for this. Fixes: bc2426d74aa3 ("net: ngbe: convert phylib to phylink") Signed-off-by: Arnd Bergmann Reviewed-by: Andrew Lunn --- This addresses a build regression in net-next at the moment, it would be good to have the fix merged into net-next before it makes it into mainline. v2: As suggested by rmk, remove the PHYLIB reference in the process, since PHYLINK requires that already --- drivers/net/ethernet/wangxun/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig index 23cd610bd376..85cdbdd44fec 100644 --- a/drivers/net/ethernet/wangxun/Kconfig +++ b/drivers/net/ethernet/wangxun/Kconfig @@ -26,7 +26,7 @@ config NGBE tristate "Wangxun(R) GbE PCI Express adapters support" depends on PCI select LIBWX - select PHYLIB + select PHYLINK help This driver supports Wangxun(R) GbE PCI Express family of adapters.