| Message ID | 20240119131652.8050-1-suresh2514@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | i40e: print correct hw max rss count in kernel ring buffer | expand |
On Fri, Jan 19, 2024 at 06:46:52PM +0530, Suresh Kumar wrote: > The value printed for "HW max RSS count" is wrong in kernel dmesg for i40e > NICs: > > ... i40e 0000:63:00.0: User requested queue count/HW max RSS count: 48/64 > > whereas ethtool reports the correct value from "vsi->num_queue_pairs" > > Channel parameters for eno33: > Pre-set maximums: > RX: n/a > TX: n/a > Other: 1 > Combined: 96 > Current hardware settings: > RX: n/a > TX: n/a > Other: 1 > Combined: 96 <------- > > and is misleading. > > This value is printed from 'pf->rss_size_max' which seems hardcoded. > > Below commit also removed this 64 limit: > > Commit e56afa599609d3afe8b0ce24b553ab95e9782502 > Author: Amritha Nambiar <amritha.nambiar@intel.com> > Date: Wed Nov 8 16:38:43 2017 -0800 > > i40e: Remove limit of 64 max queues per channel Hi Suresh, I think it would be more normal to cite this commit something like this: The limit of 64 was removed by commit e56afa599609 ("i40e: Remove limit of 64 max queues per channel") Also, it's not clear to me if this should be considered a fix or not. If not, which I lean towards, then it should probably be targeted at iwl-next. Subject: [PATCH iwl-next] ... If it is a fix, then it should have a Fixes tag and probably be targeted at iwl. Subject: [PATCH iwl] ... ...
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index d5519af34657..f5c1ec190f7e 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -12524,7 +12524,7 @@ int i40e_reconfig_rss_queues(struct i40e_pf *pf, int queue_count) i40e_pf_config_rss(pf); } dev_info(&pf->pdev->dev, "User requested queue count/HW max RSS count: %d/%d\n", - vsi->req_queue_pairs, pf->rss_size_max); + vsi->req_queue_pairs, vsi->num_queue_pairs); return pf->alloc_rss_size; }
The value printed for "HW max RSS count" is wrong in kernel dmesg for i40e NICs: ... i40e 0000:63:00.0: User requested queue count/HW max RSS count: 48/64 whereas ethtool reports the correct value from "vsi->num_queue_pairs" Channel parameters for eno33: Pre-set maximums: RX: n/a TX: n/a Other: 1 Combined: 96 Current hardware settings: RX: n/a TX: n/a Other: 1 Combined: 96 <------- and is misleading. This value is printed from 'pf->rss_size_max' which seems hardcoded. Below commit also removed this 64 limit: Commit e56afa599609d3afe8b0ce24b553ab95e9782502 Author: Amritha Nambiar <amritha.nambiar@intel.com> Date: Wed Nov 8 16:38:43 2017 -0800 i40e: Remove limit of 64 max queues per channel Signed-off-by: Suresh Kumar <suresh2514@gmail.com> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)