diff mbox series

[iwl-next] ice: remove duplicate comment

Message ID 20240122182419.889727-1-anthony.l.nguyen@intel.com (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series [iwl-next] ice: remove duplicate comment | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1077 this patch: 1077
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 0 of 0 maintainers
netdev/build_clang success Errors and warnings before: 1095 this patch: 1095
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1095 this patch: 1095
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 9 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Tony Nguyen Jan. 22, 2024, 6:24 p.m. UTC 
From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>

Remove a comment that was not correct; this structure has nothing
to do with FW alignment.

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_debugfs.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Simon Horman Jan. 24, 2024, 9:26 p.m. UTC | #1 
On Mon, Jan 22, 2024 at 10:24:17AM -0800, Tony Nguyen wrote:
> From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
> 
> Remove a comment that was not correct; this structure has nothing
> to do with FW alignment.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>

Sure, but the subject doesn't seem to match the patch description.
And, Tony, your Sob seems to be missing.

> ---
>  drivers/net/ethernet/intel/ice/ice_debugfs.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c b/drivers/net/ethernet/intel/ice/ice_debugfs.c
> index c2bfba6b9ead..85aa31dd86b1 100644
> --- a/drivers/net/ethernet/intel/ice/ice_debugfs.c
> +++ b/drivers/net/ethernet/intel/ice/ice_debugfs.c
> @@ -64,9 +64,6 @@ static const char * const ice_fwlog_level_string[] = {
>  	"verbose",
>  };
>  
> -/* the order in this array is important. it matches the ordering of the
> - * values in the FW so the index is the same value as in ice_fwlog_level
> - */
>  static const char * const ice_fwlog_log_size[] = {
>  	"128K",
>  	"256K",
Tony Nguyen Jan. 25, 2024, 5:26 p.m. UTC | #2 
On 1/24/2024 1:26 PM, Simon Horman wrote:
> On Mon, Jan 22, 2024 at 10:24:17AM -0800, Tony Nguyen wrote:
>> From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>>
>> Remove a comment that was not correct; this structure has nothing
>> to do with FW alignment.
>>
>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
> 
> Sure, but the subject doesn't seem to match the patch description.
> And, Tony, your Sob seems to be missing.

I was just kind of passing the patch along to IWL. I'll modify the 
subject to match the description and add my sob when sending on to net-next.

Thanks,
Tony
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c b/drivers/net/ethernet/intel/ice/ice_debugfs.c
index c2bfba6b9ead..85aa31dd86b1 100644
--- a/drivers/net/ethernet/intel/ice/ice_debugfs.c
+++ b/drivers/net/ethernet/intel/ice/ice_debugfs.c
@@ -64,9 +64,6 @@  static const char * const ice_fwlog_level_string[] = {
 	"verbose",
 };
 
-/* the order in this array is important. it matches the ordering of the
- * values in the FW so the index is the same value as in ice_fwlog_level
- */
 static const char * const ice_fwlog_log_size[] = {
 	"128K",
 	"256K",