| Message ID | 20240122184543.2501493-17-leitao@debian.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,01/22] net: fill in MODULE_DESCRIPTION()s for 8390 | expand |
On 1/22/2024 11:45 AM, Breno Leitao wrote: > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > Add descriptions to the Qualcom rmnet and emac drivers. > > Signed-off-by: Breno Leitao <leitao@debian.org> > --- > drivers/net/ethernet/qualcomm/emac/emac.c | 1 + > drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c > index 3270df72541b..4c06f55878de 100644 > --- a/drivers/net/ethernet/qualcomm/emac/emac.c > +++ b/drivers/net/ethernet/qualcomm/emac/emac.c > @@ -771,5 +771,6 @@ static struct platform_driver emac_platform_driver = { > > module_platform_driver(emac_platform_driver); > > +MODULE_DESCRIPTION("Qualcomm EMAC Gigabit Ethernet driver"); > MODULE_LICENSE("GPL v2"); > MODULE_ALIAS("platform:qcom-emac"); > diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c > index 5b69b9268c75..f3bea196a8f9 100644 > --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c > +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c > @@ -520,4 +520,5 @@ static void __exit rmnet_exit(void) > module_init(rmnet_init) > module_exit(rmnet_exit) > MODULE_ALIAS_RTNL_LINK("rmnet"); > +MODULE_DESCRIPTION("Qualcomm RmNet MAP driver"); > MODULE_LICENSE("GPL v2"); For rmnet Reviewed-by: Subash Abhinov Kasiviswanathan <quic_subashab@quicinc.com>
diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c index 3270df72541b..4c06f55878de 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac.c +++ b/drivers/net/ethernet/qualcomm/emac/emac.c @@ -771,5 +771,6 @@ static struct platform_driver emac_platform_driver = { module_platform_driver(emac_platform_driver); +MODULE_DESCRIPTION("Qualcomm EMAC Gigabit Ethernet driver"); MODULE_LICENSE("GPL v2"); MODULE_ALIAS("platform:qcom-emac"); diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c index 5b69b9268c75..f3bea196a8f9 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c @@ -520,4 +520,5 @@ static void __exit rmnet_exit(void) module_init(rmnet_init) module_exit(rmnet_exit) MODULE_ALIAS_RTNL_LINK("rmnet"); +MODULE_DESCRIPTION("Qualcomm RmNet MAP driver"); MODULE_LICENSE("GPL v2");
W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to the Qualcom rmnet and emac drivers. Signed-off-by: Breno Leitao <leitao@debian.org> --- drivers/net/ethernet/qualcomm/emac/emac.c | 1 + drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 1 + 2 files changed, 2 insertions(+)