| Message ID | 20240129191059.129030-1-parav@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1a89e24f8bfd3e3562d69709c9d9cd185ded869b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] devlink: Fix referring to hw_addr attribute during state validation | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 29 Jan 2024 21:10:59 +0200 you wrote: > When port function state change is requested, and when the driver > does not support it, it refers to the hw address attribute instead > of state attribute. Seems like a copy paste error. > > Fix it by referring to the port function state attribute. > > Fixes: c0bea69d1ca7 ("devlink: Validate port function request") > Signed-off-by: Parav Pandit <parav@nvidia.com> > Reviewed-by: Jiri Pirko <jiri@nvidia.com> > > [...] Here is the summary with links: - [net] devlink: Fix referring to hw_addr attribute during state validation https://git.kernel.org/netdev/net/c/1a89e24f8bfd You are awesome, thank you!
diff --git a/net/devlink/port.c b/net/devlink/port.c index 62e54e152ecf..78592912f657 100644 --- a/net/devlink/port.c +++ b/net/devlink/port.c @@ -674,7 +674,7 @@ static int devlink_port_function_validate(struct devlink_port *devlink_port, return -EOPNOTSUPP; } if (tb[DEVLINK_PORT_FN_ATTR_STATE] && !ops->port_fn_state_set) { - NL_SET_ERR_MSG_ATTR(extack, tb[DEVLINK_PORT_FUNCTION_ATTR_HW_ADDR], + NL_SET_ERR_MSG_ATTR(extack, tb[DEVLINK_PORT_FN_ATTR_STATE], "Function does not support state setting"); return -EOPNOTSUPP; }
When port function state change is requested, and when the driver does not support it, it refers to the hw address attribute instead of state attribute. Seems like a copy paste error. Fix it by referring to the port function state attribute. Fixes: c0bea69d1ca7 ("devlink: Validate port function request") Signed-off-by: Parav Pandit <parav@nvidia.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com> --- net/devlink/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)