[bpf-next,v2,1/4] riscv, bpf: Remove redundant ctx->offset initialization

Commit Message

Pu Lehui Jan. 30, 2024, 4:09 a.m. UTC

From: Pu Lehui <[e-mail]>

There is no gain in initializing ctx->offset and prev_insns, and
ctx->offset is already zero-initialized. Let's remove this code.

Signed-off-by: Pu Lehui <[e-mail]>
---
 arch/riscv/net/bpf_jit_core.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Björn Töpel Jan. 30, 2024, 4:04 p.m. UTC | #1

Pu Lehui <[e-mail]> writes:

> From: Pu Lehui <[e-mail]>
>
> There is no gain in initializing ctx->offset and prev_insns, and
> ctx->offset is already zero-initialized. Let's remove this code.
>
> Signed-off-by: Pu Lehui <[e-mail]>

Acked-by: Björn Töpel <[e-mail]>

Patch

diff --git a/arch/riscv/net/bpf_jit_core.c b/arch/riscv/net/bpf_jit_core.c
index 7b70ccb7fec3..b271240f48c9 100644
--- a/arch/riscv/net/bpf_jit_core.c
+++ b/arch/riscv/net/bpf_jit_core.c
@@ -91,11 +91,6 @@  struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog)
 		goto out_offset;
 	}
 
-	for (i = 0; i < prog->len; i++) {
-		prev_ninsns += 32;
-		ctx->offset[i] = prev_ninsns;
-	}
-
 	for (i = 0; i < NR_JIT_ITERATIONS; i++) {
 		pass++;
 		ctx->ninsns = 0;