| Message ID | 20240130104243.3025393-2-leitao@debian.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | wifi: Fix MODULE_DESCRIPTION() for net (p4) | expand |
Breno Leitao <leitao@debian.org> wrote: > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > Add descriptions to the TI WLAN wlcore drivers. > > Signed-off-by: Breno Leitao <leitao@debian.org> These patches go to wireless-next, not net. But no need to resend because of this.
On Tue, 30 Jan 2024 13:23:34 +0000 (UTC) Kalle Valo wrote: > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > > Add descriptions to the TI WLAN wlcore drivers. > > > > Signed-off-by: Breno Leitao <leitao@debian.org> > > These patches go to wireless-next, not net. But no need to resend because of this. FWIW I've been taking these thru net (or wireless in your case) rather than the -next tree. There's zero chance of regression here and the warnings are annoying. But up to you.
Jakub Kicinski <kuba@kernel.org> writes: > On Tue, 30 Jan 2024 13:23:34 +0000 (UTC) Kalle Valo wrote: >> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). >> > Add descriptions to the TI WLAN wlcore drivers. >> > >> > Signed-off-by: Breno Leitao <leitao@debian.org> >> >> These patches go to wireless-next, not net. But no need to resend because of this. > > FWIW I've been taking these thru net (or wireless in your case) > rather than the -next tree. There's zero chance of regression > here and the warnings are annoying. But up to you. Good point, I'll take them to wireless. Thanks.
Breno Leitao <leitao@debian.org> wrote: > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > Add descriptions to the TI WLAN wlcore drivers. > > Signed-off-by: Breno Leitao <leitao@debian.org> 9 patches applied to wireless.git, thanks. 5b778e1c2e97 wifi: fill in MODULE_DESCRIPTION()s for wlcore 2f2b503ea770 wifi: fill in MODULE_DESCRIPTION()s for wl1251 and wl12xx 257ca10c7317 wifi: fill in MODULE_DESCRIPTION()s for Broadcom WLAN f8782ea450ad wifi: fill in MODULE_DESCRIPTION()s for ar5523 e063d2a05d71 wifi: fill in MODULE_DESCRIPTION()s for wcn36xx 714ea2f109d9 wifi: fill in MODULE_DESCRIPTION()s for p54spi 35337ac47260 wifi: fill in MODULE_DESCRIPTION()s for wl18xx c9013880284d wifi: fill in MODULE_DESCRIPTION()s for wilc1000 f3f8f0503168 wifi: fill in MODULE_DESCRIPTION()s for mt76 drivers
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c index fb9ed97774c7..5736acb4d206 100644 --- a/drivers/net/wireless/ti/wlcore/main.c +++ b/drivers/net/wireless/ti/wlcore/main.c @@ -6793,6 +6793,7 @@ MODULE_PARM_DESC(bug_on_recovery, "BUG() on fw recovery"); module_param(no_recovery, int, 0600); MODULE_PARM_DESC(no_recovery, "Prevent HW recovery. FW will remain stuck."); +MODULE_DESCRIPTION("TI WLAN core driver"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Luciano Coelho <coelho@ti.com>"); MODULE_AUTHOR("Juuso Oikarinen <juuso.oikarinen@nokia.com>"); diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c index f0686635db46..eb5482ed76ae 100644 --- a/drivers/net/wireless/ti/wlcore/sdio.c +++ b/drivers/net/wireless/ti/wlcore/sdio.c @@ -447,6 +447,7 @@ module_sdio_driver(wl1271_sdio_driver); module_param(dump, bool, 0600); MODULE_PARM_DESC(dump, "Enable sdio read/write dumps."); +MODULE_DESCRIPTION("TI WLAN SDIO helpers"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Luciano Coelho <coelho@ti.com>"); MODULE_AUTHOR("Juuso Oikarinen <juuso.oikarinen@nokia.com>"); diff --git a/drivers/net/wireless/ti/wlcore/spi.c b/drivers/net/wireless/ti/wlcore/spi.c index 7d9a139db59e..0aa2b2f3c5c9 100644 --- a/drivers/net/wireless/ti/wlcore/spi.c +++ b/drivers/net/wireless/ti/wlcore/spi.c @@ -562,6 +562,7 @@ static struct spi_driver wl1271_spi_driver = { }; module_spi_driver(wl1271_spi_driver); +MODULE_DESCRIPTION("TI WLAN SPI helpers"); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Luciano Coelho <coelho@ti.com>"); MODULE_AUTHOR("Juuso Oikarinen <juuso.oikarinen@nokia.com>");
W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to the TI WLAN wlcore drivers. Signed-off-by: Breno Leitao <leitao@debian.org> --- drivers/net/wireless/ti/wlcore/main.c | 1 + drivers/net/wireless/ti/wlcore/sdio.c | 1 + drivers/net/wireless/ti/wlcore/spi.c | 1 + 3 files changed, 3 insertions(+)