| Message ID | 20240131085426.45374-2-louis.peens@corigine.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | nfp: series of minor driver improvements | expand |
Wed, Jan 31, 2024 at 09:54:25AM CET, louis.peens@corigine.com wrote: >From: Fei Qin <fei.qin@corigine.com> > >Newer NIC will introduce a new part number field, add it to devlink >device info. > >Signed-off-by: Fei Qin <fei.qin@corigine.com> >Signed-off-by: Louis Peens <louis.peens@corigine.com> >--- > drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c >index 635d33c0d6d3..91563b705639 100644 >--- a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c >+++ b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c >@@ -160,6 +160,7 @@ static const struct nfp_devlink_versions_simple { > { DEVLINK_INFO_VERSION_GENERIC_BOARD_REV, "assembly.revision", }, > { DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE, "assembly.vendor", }, > { "board.model", /* code name */ "assembly.model", }, >+ { "board.pn", "pn", }, This looks quite generic. Could you please introduce: DEVLINK_INFO_VERSION_GENERIC_BOARD_MODEL DEVLINK_INFO_VERSION_GENERIC_BOARD_PN and use those while you are at it? Thanks! pw-bot: cr
On Wed, Jan 31, 2024 at 10:31:51AM +0100, Jiri Pirko wrote: > Wed, Jan 31, 2024 at 09:54:25AM CET, louis.peens@corigine.com wrote: > >From: Fei Qin <fei.qin@corigine.com> > > > >Newer NIC will introduce a new part number field, add it to devlink > >device info. > > > >Signed-off-by: Fei Qin <fei.qin@corigine.com> > >Signed-off-by: Louis Peens <louis.peens@corigine.com> > >--- > > drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c > >index 635d33c0d6d3..91563b705639 100644 > >--- a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c > >+++ b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c > >@@ -160,6 +160,7 @@ static const struct nfp_devlink_versions_simple { > > { DEVLINK_INFO_VERSION_GENERIC_BOARD_REV, "assembly.revision", }, > > { DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE, "assembly.vendor", }, > > { "board.model", /* code name */ "assembly.model", }, > >+ { "board.pn", "pn", }, > > This looks quite generic. Could you please introduce: > DEVLINK_INFO_VERSION_GENERIC_BOARD_MODEL > DEVLINK_INFO_VERSION_GENERIC_BOARD_PN > and use those while you are at it? We will do so, thanks. > > Thanks! > > pw-bot: cr
On Wed, 31 Jan 2024 10:54:25 +0200 Louis Peens wrote:
> + { "board.pn", "pn", },
"part_number", spell it out, please.
Why "board"? Part number is for the entire product, isn't it?
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c index 635d33c0d6d3..91563b705639 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c @@ -160,6 +160,7 @@ static const struct nfp_devlink_versions_simple { { DEVLINK_INFO_VERSION_GENERIC_BOARD_REV, "assembly.revision", }, { DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE, "assembly.vendor", }, { "board.model", /* code name */ "assembly.model", }, + { "board.pn", "pn", }, }; static int