| Message ID | 20240204-unify-c22-c45-scan-error-handling-v2-2-0273623f9c57@lunn.ch (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 88b3934e3f31e15b40896aa8ebb0a8040d150c1c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Unify C22 and C45 error handling during bus enumeration | expand |
On 2/4/2024 3:14 PM, Andrew Lunn wrote: > MDIO bus drivers can return -ENODEV when they know the bus does not > have a device at the given address, e.g. because of hardware > limitation. One such limitation is that the bus does not support C45 > at all. This is more efficient than returning 0xffff, since it > immediately stops the probing on the given address, where as further > reads can be made when 0xffff is returned. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 6eec2e4aa031..9caecb4dfbfa 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3659,7 +3659,7 @@ static int mv88e6xxx_mdio_read_c45(struct mii_bus *bus, int phy, int devad, int err; if (!chip->info->ops->phy_read_c45) - return 0xffff; + return -ENODEV; mv88e6xxx_reg_lock(chip); err = chip->info->ops->phy_read_c45(chip, bus, phy, devad, reg, &val);
MDIO bus drivers can return -ENODEV when they know the bus does not have a device at the given address, e.g. because of hardware limitation. One such limitation is that the bus does not support C45 at all. This is more efficient than returning 0xffff, since it immediately stops the probing on the given address, where as further reads can be made when 0xffff is returned. Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)