From patchwork Thu Feb 8 06:30:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yonghong Song X-Patchwork-Id: 13549367 X-Patchwork-Delegate: bpf@iogearbox.net Received: from 66-220-155-179.mail-mxout.facebook.com (66-220-155-179.mail-mxout.facebook.com [66.220.155.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF5A567E95 for ; Thu, 8 Feb 2024 06:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.220.155.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707373831; cv=none; b=Ze5ehSDcjqf3E+TkDWctAxNCzDzDTtHzGDDLzLFVfRcCAVULLJes1K+TtX1E0PQ+Me+qJrd70NaexS1U17Tr0riRLsAJw2VKneYJsUZu0ZexD/JvjYFmMGHhQbePHUQbmfwWlE7aKQgGOWfC6hfpS4RaNFzYOuSbNm9Qqf9XgDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707373831; c=relaxed/simple; bh=g7cMBzQ9PcdLLCrcgouFWmtnHhEp/iuVczebiWL/lq4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=b8vt6mvjbQDD4igB5ITRL8Po86pZ1u+DBWi5sAOQC/jQkiMqPRrtl0HqSkGYoUMya6z/ahTAIiVnUHzCvqZOhr3IdeYW9XvxubSEkEEmuSYS8pINAYr1zkTp0SuV6pfJRbV9kTK5qHaxIRCmZgXSxbnXGGljZIieWG3GS71UHLY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.dev; spf=fail smtp.mailfrom=linux.dev; arc=none smtp.client-ip=66.220.155.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=linux.dev Received: by devbig309.ftw3.facebook.com (Postfix, from userid 128203) id 41EF51ECDB2; Wed, 7 Feb 2024 22:30:20 -0800 (PST) From: Yonghong Song To: bpf@vger.kernel.org Cc: Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , kernel-team@fb.com, Martin KaFai Lau Subject: [PATCH bpf-next v2 2/2] selftests/bpf: Add a negative test for stack accounting in jit mode Date: Wed, 7 Feb 2024 22:30:20 -0800 Message-Id: <20240208063020.3893932-1-yonghong.song@linux.dev> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240208063015.3893418-1-yonghong.song@linux.dev> References: <20240208063015.3893418-1-yonghong.song@linux.dev> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: bpf@iogearbox.net The new test is very similar to test_global_func1.c, but is modified to fail on jit mode. Signed-off-by: Yonghong Song --- .../bpf/prog_tests/test_global_funcs.c | 3 ++ .../selftests/bpf/progs/test_global_func18.c | 44 +++++++++++++++++++ 2 files changed, 47 insertions(+) create mode 100644 tools/testing/selftests/bpf/progs/test_global_func18.c diff --git a/tools/testing/selftests/bpf/prog_tests/test_global_funcs.c b/tools/testing/selftests/bpf/prog_tests/test_global_funcs.c index a3a41680b38e..dccbf2213135 100644 --- a/tools/testing/selftests/bpf/prog_tests/test_global_funcs.c +++ b/tools/testing/selftests/bpf/prog_tests/test_global_funcs.c @@ -18,6 +18,7 @@ #include "test_global_func15.skel.h" #include "test_global_func16.skel.h" #include "test_global_func17.skel.h" +#include "test_global_func18.skel.h" #include "test_global_func_ctx_args.skel.h" #include "bpf/libbpf_internal.h" @@ -140,6 +141,8 @@ void test_test_global_funcs(void) { if (!env.jit_enabled) { RUN_TESTS(test_global_func1); + } else { + RUN_TESTS(test_global_func18); } RUN_TESTS(test_global_func2); diff --git a/tools/testing/selftests/bpf/progs/test_global_func18.c b/tools/testing/selftests/bpf/progs/test_global_func18.c new file mode 100644 index 000000000000..d1aa3b2c68fe --- /dev/null +++ b/tools/testing/selftests/bpf/progs/test_global_func18.c @@ -0,0 +1,44 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* Copyright (c) 2024 Meta Platforms, Inc. and affiliates. */ +#include +#include +#include +#include "bpf_misc.h" + +#define MAX_STACK1 (512 - 3 * 32 + 8) +#define MAX_STACK2 (3 * 32) + +__attribute__ ((noinline)) +int f1(struct __sk_buff *skb) +{ + return skb->len; +} + +int f3(int, struct __sk_buff *skb, int); + +__attribute__ ((noinline)) +int f2(int val, struct __sk_buff *skb) +{ + volatile char buf[MAX_STACK1] = {}; + + __sink(buf[MAX_STACK1 - 1]); + + return f1(skb) + f3(val, skb, 1); +} + +__attribute__ ((noinline)) +int f3(int val, struct __sk_buff *skb, int var) +{ + volatile char buf[MAX_STACK2] = {}; + + __sink(buf[MAX_STACK2 - 1]); + + return skb->ifindex * val * var; +} + +SEC("tc") +__failure __msg("combined stack size of 3 calls is 528") +int global_func18(struct __sk_buff *skb) +{ + return f1(skb) + f2(2, skb) + f3(3, skb, 4); +}