diff mbox series

tcp_metrics: fix possible memory leak in tcp_metrics_init()

Message ID 20240215202949.29879-1-kovalev@altlinux.org (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series tcp_metrics: fix possible memory leak in tcp_metrics_init() | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 991 this patch: 991
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 1007 this patch: 1007
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 1008 this patch: 1008
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 9 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest fail net-next-2024-02-16--00-00 (tests: 1436)

Commit Message

Vasiliy Kovalev Feb. 15, 2024, 8:29 p.m. UTC 
From: Vasiliy Kovalev <kovalev@altlinux.org>

Fixes: 6493517eaea9 ("tcp_metrics: panic when tcp_metrics_init fails.")
Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
---
 net/ipv4/tcp_metrics.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Eric Dumazet Feb. 15, 2024, 8:34 p.m. UTC | #1 
On Thu, Feb 15, 2024 at 9:29 PM <kovalev@altlinux.org> wrote:
>
> From: Vasiliy Kovalev <kovalev@altlinux.org>
>
> Fixes: 6493517eaea9 ("tcp_metrics: panic when tcp_metrics_init fails.")
> Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
> ---
>  net/ipv4/tcp_metrics.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/ipv4/tcp_metrics.c b/net/ipv4/tcp_metrics.c
> index c2a925538542b5..517c7f801dc220 100644
> --- a/net/ipv4/tcp_metrics.c
> +++ b/net/ipv4/tcp_metrics.c
> @@ -1048,6 +1048,8 @@ void __init tcp_metrics_init(void)
>                 panic("Could not register tcp_net_metrics_ops\n");
>
>         ret = genl_register_family(&tcp_metrics_nl_family);
> -       if (ret < 0)
> +       if (ret < 0) {
>                 panic("Could not register tcp_metrics generic netlink\n");
> +               unregister_pernet_subsys(&tcp_net_metrics_ops);
> +       }
>  }

Well, the whole point of panic() is to crash the host.

We do not expect to recover.
diff mbox series

Patch

diff --git a/net/ipv4/tcp_metrics.c b/net/ipv4/tcp_metrics.c
index c2a925538542b5..517c7f801dc220 100644
--- a/net/ipv4/tcp_metrics.c
+++ b/net/ipv4/tcp_metrics.c
@@ -1048,6 +1048,8 @@  void __init tcp_metrics_init(void)
 		panic("Could not register tcp_net_metrics_ops\n");
 
 	ret = genl_register_family(&tcp_metrics_nl_family);
-	if (ret < 0)
+	if (ret < 0) {
 		panic("Could not register tcp_metrics generic netlink\n");
+		unregister_pernet_subsys(&tcp_net_metrics_ops);
+	}
 }