From patchwork Sat Feb 17 10:03:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13561293 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E047C1DFFA for ; Sat, 17 Feb 2024 10:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708164195; cv=none; b=JOWzgY3OJiSbpvcB9aVQjb9eQU3luI/k4MrGd6ZNCeQDfWzu9j17+8laUxxOzObtpcfmNFhz9Z1Lq6u8QkW/szcw1OS62oj+6C/NgRrDa/viXrvJvu9vdqiSa48H2Cby8SoHHziW/2hDWKlucjRHdbZ1ltZGTd7fQfO5d6rdsSw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708164195; c=relaxed/simple; bh=A+8Z4F2C+Jafe+RXMmROAWtPHvoM9Qp4Vx4sW0hunfg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=tFY/UD89+xfgm2Vkqi6P3J43dPD9zLwkK4Dsz4NR8eU42m0uhqS2Q/DN31CErK/anH+iWPnqYHlJ7I3b1i3DKo4NqTEAi9FeeLY7S3VXSEdUArxHnL6PcgtHJcttfsGkieopRwLJLvgsGvHj9UlL/jigVIPCsF9CPpROho7k/WM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rUTVc7hK; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rUTVc7hK" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a3cfacf0eadso326807066b.2 for ; Sat, 17 Feb 2024 02:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708164188; x=1708768988; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9YKX8C3qTGETErqkeCa13vk3aSbkZKOlK79FCs1RlfM=; b=rUTVc7hKJTdknUxy8QRv5PMaU1rwGqMJQjWX1GhFqg3v1Pt6yFd4PsD12WPZby20wF BYV9+FqGYD3keqKdva41RfCg9cSiRuuoa1NUJwA/Cxta2kY8Ygt0ufrqATpC9eAl+nTQ 5wMLAfPA7vKqOjFYc3mjtUp8t00NgVdS+qJI4mXxnO/6S5GNhAk+OpR0sZXGOtTblbzD rAlOVwIrmT4artZVY+C+LcyLmNV4bCaju9Ne8SYTTeuzlmg/JF+0mwq9J4rU99tcHs2V pZzWQFIrCS1YOBhEZ2qmLPruVyDeFrtI9rcgv5zRMld0ND8MbA7zRDDe+QbIiDUaAhGV dAsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708164188; x=1708768988; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9YKX8C3qTGETErqkeCa13vk3aSbkZKOlK79FCs1RlfM=; b=cChZ1kpCUAM1GTFLbhQy75Twv5JcxVTzieDeCZB7z1UQsJerxX+ZRC3GN2UM3krNsT SwYPcD4qEbSMMXiZggwOsgFYK6y5huRQ8ROMOhUUBN0RFoTScf7zUm/0CC05wt5Z/DCd xby4SL2omW/iqLD7s6RFOjIQV2nnKPpFp93t3bC9jc9GIi1WV52wqgUVQCvwMSnGPrJT eTNb1j68Bfzcq+HB7gzni8iiF8gpUYFklOghI9XK//AxzlURfxo/mYQZoPrm7rAohHVN wr8F42xI5P2Hj1Yky0GZdgxlb3N6m32reOM4/5lG1ozHlr+gBdZYbey5+JN58WHDUgx+ GX7w== X-Forwarded-Encrypted: i=1; AJvYcCVcxyxlCWLO4837OwUdvA0Qbw1i6kuUX0TGPhUdz92+IFbjRHffJb3H7f4/AAAdLf3KGSxGG/Bw1Rvj/5yBSq1DvWAx9tiH X-Gm-Message-State: AOJu0YzpqE+ewQmt+TdjQQw5wROWJn7xmwRttUxKmFxUTz8jWtw8CbCQ KXuitawg3BXgSfqwJ4IrB1rVeDl7iXhpbDZxY12tMiq+sE5zm5DU/qW+fMp+fGw= X-Google-Smtp-Source: AGHT+IEB7coatVc1HZNyq1lKyqGs5tBMkLSGt/qgM6tjFvuATdq9Q/ZJKE3BoDsFElc7NBbg6Vl5JA== X-Received: by 2002:a17:906:3d2:b0:a3c:e8f6:a399 with SMTP id c18-20020a17090603d200b00a3ce8f6a399mr4796446eja.29.1708164188372; Sat, 17 Feb 2024 02:03:08 -0800 (PST) Received: from krzk-bin.. ([78.10.207.130]) by smtp.gmail.com with ESMTPSA id fj6-20020a1709069c8600b00a3cfe376116sm844862ejc.57.2024.02.17.02.03.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Feb 2024 02:03:07 -0800 (PST) From: Krzysztof Kozlowski To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RESEND PATCH net-next] net: wan: framer: constify of_phandle_args in xlate Date: Sat, 17 Feb 2024 11:03:06 +0100 Message-Id: <20240217100306.86740-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org The xlate callbacks are supposed to translate of_phandle_args to proper provider without modifying the of_phandle_args. Make the argument pointer to const for code safety and readability. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Simon Horman --- drivers/net/wan/framer/framer-core.c | 9 +++++---- include/linux/framer/framer-provider.h | 14 +++++++------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/net/wan/framer/framer-core.c b/drivers/net/wan/framer/framer-core.c index c04dc88bda6c..33b358b99f70 100644 --- a/drivers/net/wan/framer/framer-core.c +++ b/drivers/net/wan/framer/framer-core.c @@ -384,7 +384,7 @@ static struct framer_provider *framer_provider_of_lookup(const struct device_nod return ERR_PTR(-EPROBE_DEFER); } -static struct framer *framer_of_get_from_provider(struct of_phandle_args *args) +static struct framer *framer_of_get_from_provider(const struct of_phandle_args *args) { struct framer_provider *framer_provider; struct framer *framer; @@ -735,7 +735,8 @@ EXPORT_SYMBOL_GPL(devm_framer_create); * should provide a custom of_xlate function that reads the *args* and returns * the appropriate framer. */ -struct framer *framer_provider_simple_of_xlate(struct device *dev, struct of_phandle_args *args) +struct framer *framer_provider_simple_of_xlate(struct device *dev, + const struct of_phandle_args *args) { struct class_dev_iter iter; struct framer *framer; @@ -768,7 +769,7 @@ EXPORT_SYMBOL_GPL(framer_provider_simple_of_xlate); struct framer_provider * __framer_provider_of_register(struct device *dev, struct module *owner, struct framer *(*of_xlate)(struct device *dev, - struct of_phandle_args *args)) + const struct of_phandle_args *args)) { struct framer_provider *framer_provider; @@ -830,7 +831,7 @@ static void devm_framer_provider_of_unregister(struct device *dev, void *res) struct framer_provider * __devm_framer_provider_of_register(struct device *dev, struct module *owner, struct framer *(*of_xlate)(struct device *dev, - struct of_phandle_args *args)) + const struct of_phandle_args *args)) { struct framer_provider **ptr, *framer_provider; diff --git a/include/linux/framer/framer-provider.h b/include/linux/framer/framer-provider.h index 782cd5fc83d5..f6fd2dd92591 100644 --- a/include/linux/framer/framer-provider.h +++ b/include/linux/framer/framer-provider.h @@ -93,7 +93,7 @@ struct framer_provider { struct module *owner; struct list_head list; struct framer * (*of_xlate)(struct device *dev, - struct of_phandle_args *args); + const struct of_phandle_args *args); }; static inline void framer_set_drvdata(struct framer *framer, void *data) @@ -118,19 +118,19 @@ struct framer *devm_framer_create(struct device *dev, struct device_node *node, const struct framer_ops *ops); struct framer *framer_provider_simple_of_xlate(struct device *dev, - struct of_phandle_args *args); + const struct of_phandle_args *args); struct framer_provider * __framer_provider_of_register(struct device *dev, struct module *owner, struct framer *(*of_xlate)(struct device *dev, - struct of_phandle_args *args)); + const struct of_phandle_args *args)); void framer_provider_of_unregister(struct framer_provider *framer_provider); struct framer_provider * __devm_framer_provider_of_register(struct device *dev, struct module *owner, struct framer *(*of_xlate)(struct device *dev, - struct of_phandle_args *args)); + const struct of_phandle_args *args)); void framer_notify_status_change(struct framer *framer); @@ -154,7 +154,7 @@ static inline struct framer *devm_framer_create(struct device *dev, struct devic } static inline struct framer *framer_provider_simple_of_xlate(struct device *dev, - struct of_phandle_args *args) + const struct of_phandle_args *args) { return ERR_PTR(-ENOSYS); } @@ -162,7 +162,7 @@ static inline struct framer *framer_provider_simple_of_xlate(struct device *dev, static inline struct framer_provider * __framer_provider_of_register(struct device *dev, struct module *owner, struct framer *(*of_xlate)(struct device *dev, - struct of_phandle_args *args)) + const struct of_phandle_args *args)) { return ERR_PTR(-ENOSYS); } @@ -174,7 +174,7 @@ void framer_provider_of_unregister(struct framer_provider *framer_provider) static inline struct framer_provider * __devm_framer_provider_of_register(struct device *dev, struct module *owner, struct framer *(*of_xlate)(struct device *dev, - struct of_phandle_args *args)) + const struct of_phandle_args *args)) { return ERR_PTR(-ENOSYS); }