| Message ID | 20240221103514.968815-1-siyanteng@loongson.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: stmmac: fix typo in comment | expand |
Hi Yanteng On Wed, Feb 21, 2024 at 06:35:14PM +0800, Yanteng Si wrote: > This is just a trivial fix for a typo in a comment, no functional > changes. > > Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") > Signed-off-by: Yanteng Si <siyanteng@loongson.cn> Thanks for submitting the patch. Reviewed-by: Serge Semin <fancer.lancer@gmail.com> -Serge(y) > --- > In fact, it was discovered during the review of the Loongson > driver patch.:) > > drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h > index 358e7dcb6a9a..9d640ba5c323 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h > @@ -92,7 +92,7 @@ > #define DMA_TBS_FTOV BIT(0) > #define DMA_TBS_DEF_FTOS (DMA_TBS_FTOS | DMA_TBS_FTOV) > > -/* Following DMA defines are chanels oriented */ > +/* Following DMA defines are channels oriented */ > #define DMA_CHAN_BASE_ADDR 0x00001100 > #define DMA_CHAN_BASE_OFFSET 0x80 > > -- > 2.31.4 >
On Wed, 21 Feb 2024 18:35:14 +0800 Yanteng Si wrote: > This is just a trivial fix for a typo in a comment, no functional > changes. > > Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") Fixes is reserved for functional bugs, let's leave it out for a typo correction. > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h > index 358e7dcb6a9a..9d640ba5c323 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h > @@ -92,7 +92,7 @@ > #define DMA_TBS_FTOV BIT(0) > #define DMA_TBS_DEF_FTOS (DMA_TBS_FTOS | DMA_TBS_FTOV) > > -/* Following DMA defines are chanels oriented */ > +/* Following DMA defines are channels oriented */ I'm not a native speaker but I'd spell it "... are channel-oriented" With a hyphen, channel not channels. > #define DMA_CHAN_BASE_ADDR 0x00001100 > #define DMA_CHAN_BASE_OFFSET 0x80 >
在 2024/2/23 11:12, Jakub Kicinski 写道: > On Wed, 21 Feb 2024 18:35:14 +0800 Yanteng Si wrote: >> This is just a trivial fix for a typo in a comment, no functional >> changes. >> >> Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") > Fixes is reserved for functional bugs, let's leave it out > for a typo correction. OK! I will remove it. Thanks, Yanteng >> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h >> index 358e7dcb6a9a..9d640ba5c323 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h >> @@ -92,7 +92,7 @@ >> #define DMA_TBS_FTOV BIT(0) >> #define DMA_TBS_DEF_FTOS (DMA_TBS_FTOS | DMA_TBS_FTOV) >> >> -/* Following DMA defines are chanels oriented */ >> +/* Following DMA defines are channels oriented */ > I'm not a native speaker but I'd spell it "... are channel-oriented" > With a hyphen, channel not channels. > >> #define DMA_CHAN_BASE_ADDR 0x00001100 >> #define DMA_CHAN_BASE_OFFSET 0x80 >>
在 2024/2/23 11:12, Jakub Kicinski 写道: > On Wed, 21 Feb 2024 18:35:14 +0800 Yanteng Si wrote: >> This is just a trivial fix for a typo in a comment, no functional >> changes. >> >> Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") > Fixes is reserved for functional bugs, let's leave it out > for a typo correction. > >> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h >> index 358e7dcb6a9a..9d640ba5c323 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h >> @@ -92,7 +92,7 @@ >> #define DMA_TBS_FTOV BIT(0) >> #define DMA_TBS_DEF_FTOS (DMA_TBS_FTOS | DMA_TBS_FTOV) >> >> -/* Following DMA defines are chanels oriented */ >> +/* Following DMA defines are channels oriented */ > I'm not a native speaker but I'd spell it "... are channel-oriented" > With a hyphen, channel not channels. OK. Thanks, Yanteng >> #define DMA_CHAN_BASE_ADDR 0x00001100 >> #define DMA_CHAN_BASE_OFFSET 0x80 >>
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h index 358e7dcb6a9a..9d640ba5c323 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h @@ -92,7 +92,7 @@ #define DMA_TBS_FTOV BIT(0) #define DMA_TBS_DEF_FTOS (DMA_TBS_FTOS | DMA_TBS_FTOV) -/* Following DMA defines are chanels oriented */ +/* Following DMA defines are channels oriented */ #define DMA_CHAN_BASE_ADDR 0x00001100 #define DMA_CHAN_BASE_OFFSET 0x80
This is just a trivial fix for a typo in a comment, no functional changes. Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") Signed-off-by: Yanteng Si <siyanteng@loongson.cn> --- In fact, it was discovered during the review of the Loongson driver patch.:) drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)