| Message ID | 20240222190441.2610930-12-alan.brady@intel.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | idpf: refactor virtchnl messages | expand |
> -----Original Message----- > From: Alan Brady <alan.brady@intel.com> > Sent: Thursday, February 22, 2024 11:05 AM > To: intel-wired-lan@lists.osuosl.org > Cc: netdev@vger.kernel.org; Brady, Alan <alan.brady@intel.com>; Lobakin, > Aleksander <aleksander.lobakin@intel.com> > Subject: [PATCH v6 11/11 iwl-next] idpf: remove dealloc vector msg err in > idpf_intr_rel > > This error message is at best not really helpful and at worst > misleading. If we're here in idpf_intr_rel we're likely trying to do > remove or reset. If we're in reset, this message will fail because we > lose the virtchnl on reset and HW is going to clean up those resources > regardless in that case. If we're in remove and we get an error here, > we're going to reset the device at the end of remove anyway so not a big > deal. Just remove this message it's not useful. > > Tested-by: Alexander Lobakin <aleksander.lobakin@intel.com> > Signed-off-by: Alan Brady <alan.brady@intel.com> > --- > drivers/net/ethernet/intel/idpf/idpf_lib.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c > b/drivers/net/ethernet/intel/idpf/idpf_lib.c > index 0714d7dcab10..5d3532c27d57 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c > +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c index 0714d7dcab10..5d3532c27d57 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c @@ -79,19 +79,12 @@ static void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter) */ void idpf_intr_rel(struct idpf_adapter *adapter) { - int err; - if (!adapter->msix_entries) return; idpf_mb_intr_rel_irq(adapter); pci_free_irq_vectors(adapter->pdev); - - err = idpf_send_dealloc_vectors_msg(adapter); - if (err) - dev_err(&adapter->pdev->dev, - "Failed to deallocate vectors: %d\n", err); - + idpf_send_dealloc_vectors_msg(adapter); idpf_deinit_vector_stack(adapter); kfree(adapter->msix_entries); adapter->msix_entries = NULL;