diff mbox series

[net-next,resend,2/6] dt-bindings: net: brcm,asp-v2.0: Add asp-v2.2

Message ID 20240223222434.590191-3-justin.chen@broadcom.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series Support for ASP 2.2 and optimizations | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 11 of 11 maintainers
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 10 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-02-25--03-00 (tests: 1457)

Commit Message

Justin Chen Feb. 23, 2024, 10:24 p.m. UTC 
Add support for ASP 2.2.

Signed-off-by: Justin Chen <justin.chen@broadcom.com>
---
 Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski Feb. 24, 2024, 10:22 a.m. UTC | #1 
On 23/02/2024 23:24, Justin Chen wrote:
> Add support for ASP 2.2.
> 
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> ---
>  Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> index 75d8138298fb..5a345f03de17 100644
> --- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> @@ -15,6 +15,10 @@ description: Broadcom Ethernet controller first introduced with 72165
>  properties:
>    compatible:
>      oneOf:
> +      - items:
> +          - enum:
> +              - brcm,bcm74165-asp
> +          - const: brcm,asp-v2.2
>        - items:
>            - enum:
>                - brcm,bcm74165-asp

Hm, this confuses me: why do you have same SoC with three different
versions of the same block?

Best regards,
Krzysztof
Justin Chen Feb. 26, 2024, 7:42 p.m. UTC | #2 
On 2/24/24 2:22 AM, Krzysztof Kozlowski wrote:
> On 23/02/2024 23:24, Justin Chen wrote:
>> Add support for ASP 2.2.
>>
>> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
>> ---
>>   Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> index 75d8138298fb..5a345f03de17 100644
>> --- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> @@ -15,6 +15,10 @@ description: Broadcom Ethernet controller first introduced with 72165
>>   properties:
>>     compatible:
>>       oneOf:
>> +      - items:
>> +          - enum:
>> +              - brcm,bcm74165-asp
>> +          - const: brcm,asp-v2.2
>>         - items:
>>             - enum:
>>                 - brcm,bcm74165-asp
> 
> Hm, this confuses me: why do you have same SoC with three different
> versions of the same block?
> 

bcm72165 -> asp-v2.0
bcm74165 -> asp-v2.1
Are two different SoCs.

The entry I just added is
bcm74165 -> asp-v2.2
This is a SoC minor revision. Maybe it should bcm74165b0-asp instead? 
Not sure what the protocol is.

Thanks,
Justin

> Best regards,
> Krzysztof
>
Florian Fainelli Feb. 27, 2024, 12:07 a.m. UTC | #3 
On 2/23/24 14:24, Justin Chen wrote:
> Add support for ASP 2.2.
> 
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>

Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
Krzysztof Kozlowski Feb. 27, 2024, 6:55 a.m. UTC | #4 
On 26/02/2024 20:42, Justin Chen wrote:
> 
> 
> On 2/24/24 2:22 AM, Krzysztof Kozlowski wrote:
>> On 23/02/2024 23:24, Justin Chen wrote:
>>> Add support for ASP 2.2.
>>>
>>> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
>>> ---
>>>   Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>>> index 75d8138298fb..5a345f03de17 100644
>>> --- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>>> +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>>> @@ -15,6 +15,10 @@ description: Broadcom Ethernet controller first introduced with 72165
>>>   properties:
>>>     compatible:
>>>       oneOf:
>>> +      - items:
>>> +          - enum:
>>> +              - brcm,bcm74165-asp
>>> +          - const: brcm,asp-v2.2
>>>         - items:
>>>             - enum:
>>>                 - brcm,bcm74165-asp
>>
>> Hm, this confuses me: why do you have same SoC with three different
>> versions of the same block?
>>
> 
> bcm72165 -> asp-v2.0
> bcm74165 -> asp-v2.1
> Are two different SoCs.

Ah, right, existing bindings has two SoCs.

> 
> The entry I just added is
> bcm74165 -> asp-v2.2
> This is a SoC minor revision. Maybe it should bcm74165b0-asp instead? 
> Not sure what the protocol is.

So still the confusion - same SoC with different IP blocks. That's
totally opposite of what we expect: same version of IP block used in
multiple SoCs.



Best regards,
Krzysztof
Justin Chen Feb. 27, 2024, 7:07 a.m. UTC | #5 
On 2/26/2024 10:55 PM, Krzysztof Kozlowski wrote:
> On 26/02/2024 20:42, Justin Chen wrote:
>>
>>
>> On 2/24/24 2:22 AM, Krzysztof Kozlowski wrote:
>>> On 23/02/2024 23:24, Justin Chen wrote:
>>>> Add support for ASP 2.2.
>>>>
>>>> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>>>> index 75d8138298fb..5a345f03de17 100644
>>>> --- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>>>> @@ -15,6 +15,10 @@ description: Broadcom Ethernet controller first introduced with 72165
>>>>    properties:
>>>>      compatible:
>>>>        oneOf:
>>>> +      - items:
>>>> +          - enum:
>>>> +              - brcm,bcm74165-asp
>>>> +          - const: brcm,asp-v2.2
>>>>          - items:
>>>>              - enum:
>>>>                  - brcm,bcm74165-asp
>>>
>>> Hm, this confuses me: why do you have same SoC with three different
>>> versions of the same block?
>>>
>>
>> bcm72165 -> asp-v2.0
>> bcm74165 -> asp-v2.1
>> Are two different SoCs.
> 
> Ah, right, existing bindings has two SoCs.
> 
>>
>> The entry I just added is
>> bcm74165 -> asp-v2.2
>> This is a SoC minor revision. Maybe it should bcm74165b0-asp instead?
>> Not sure what the protocol is.
> 
> So still the confusion - same SoC with different IP blocks. That's
> totally opposite of what we expect: same version of IP block used in
> multiple SoCs.
> 
>

Agreed. Unfortunately what we expect is not always what comes to fruition...

Thinking about it again, I prefer bcm74165b0-asp. Otherwise it doesn't 
properly describe the hardware as we do not have one SoC with two 
different IP blocks.

Thanks,
Justin

> 
> Best regards,
> Krzysztof
>
Paolo Abeni Feb. 27, 2024, 11:45 a.m. UTC | #6 
On Mon, 2024-02-26 at 23:07 -0800, Justin Chen wrote:
> On 2/26/2024 10:55 PM, Krzysztof Kozlowski wrote:
> > On 26/02/2024 20:42, Justin Chen wrote:
> > > On 2/24/24 2:22 AM, Krzysztof Kozlowski wrote:
> > > > On 23/02/2024 23:24, Justin Chen wrote:
> > > > > Add support for ASP 2.2.
> > > > > 
> > > > > Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> > > > > ---
> > > > >    Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml | 4 ++++
> > > > >    1 file changed, 4 insertions(+)
> > > > > 
> > > > > diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> > > > > index 75d8138298fb..5a345f03de17 100644
> > > > > --- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> > > > > +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> > > > > @@ -15,6 +15,10 @@ description: Broadcom Ethernet controller first introduced with 72165
> > > > >    properties:
> > > > >      compatible:
> > > > >        oneOf:
> > > > > +      - items:
> > > > > +          - enum:
> > > > > +              - brcm,bcm74165-asp
> > > > > +          - const: brcm,asp-v2.2
> > > > >          - items:
> > > > >              - enum:
> > > > >                  - brcm,bcm74165-asp
> > > > 
> > > > Hm, this confuses me: why do you have same SoC with three different
> > > > versions of the same block?
> > > > 
> > > 
> > > bcm72165 -> asp-v2.0
> > > bcm74165 -> asp-v2.1
> > > Are two different SoCs.
> > 
> > Ah, right, existing bindings has two SoCs.
> > 
> > > 
> > > The entry I just added is
> > > bcm74165 -> asp-v2.2
> > > This is a SoC minor revision. Maybe it should bcm74165b0-asp instead?
> > > Not sure what the protocol is.
> > 
> > So still the confusion - same SoC with different IP blocks. That's
> > totally opposite of what we expect: same version of IP block used in
> > multiple SoCs.
> 
> Agreed. Unfortunately what we expect is not always what comes to fruition...
> 
> Thinking about it again, I prefer bcm74165b0-asp. Otherwise it doesn't 
> properly describe the hardware as we do not have one SoC with two 
> different IP blocks.

I read the above as you intend to send a v2 with an update dt-binding.
Please correct me if I'm wrong.

Meanwhile dropping this revision from PW.

Cheers,

Paolo
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
index 75d8138298fb..5a345f03de17 100644
--- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
+++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
@@ -15,6 +15,10 @@  description: Broadcom Ethernet controller first introduced with 72165
 properties:
   compatible:
     oneOf:
+      - items:
+          - enum:
+              - brcm,bcm74165-asp
+          - const: brcm,asp-v2.2
       - items:
           - enum:
               - brcm,bcm74165-asp