| Message ID | 20240229170425.3895238-2-leitao@debian.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4ab597d2962195ca4f01a429f9b2ea87ee684be3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] net: bareudp: Do not allocate stats in the driver | expand |
On Thu, Feb 29, 2024 at 09:04:24AM -0800, Breno Leitao wrote: > Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is > configured") moved the callback to dev_get_tstats64() to net core, so, > unless the driver is doing some custom stats collection, it does not > need to set .ndo_get_stats64. > > Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it > doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 > function pointer. > > Signed-off-by: Breno Leitao <leitao@debian.org> Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index 27408f0b93d6..339db6e4a1d5 100644 --- a/drivers/net/bareudp.c +++ b/drivers/net/bareudp.c @@ -523,7 +523,6 @@ static const struct net_device_ops bareudp_netdev_ops = { .ndo_open = bareudp_open, .ndo_stop = bareudp_stop, .ndo_start_xmit = bareudp_xmit, - .ndo_get_stats64 = dev_get_tstats64, .ndo_fill_metadata_dst = bareudp_fill_metadata_dst, };
Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is configured") moved the callback to dev_get_tstats64() to net core, so, unless the driver is doing some custom stats collection, it does not need to set .ndo_get_stats64. Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Signed-off-by: Breno Leitao <leitao@debian.org> --- drivers/net/bareudp.c | 1 - 1 file changed, 1 deletion(-)