diff mbox series

[net-next,v7,9/9] net: hisi_femac: remove unused MODULE_ALIAS()

Message ID 20240301-net-v7-9-45823597d4d4@outlook.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 940 this patch: 940
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 956 this patch: 956
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 956 this patch: 956
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 3 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-03-02--12-00 (tests: 884)

Commit Message

Yang Xiwen via B4 Relay March 1, 2024, 3:36 a.m. UTC 
From: Yang Xiwen <forbidden405@outlook.com>

We already have MODULE_DEVICE_TABLE(), so this MODULE_ALIAS() has no use
and should be removed.

Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
---
 drivers/net/ethernet/hisilicon/hisi_femac.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Krzysztof Kozlowski March 1, 2024, 6:50 a.m. UTC | #1 
On 01/03/2024 04:36, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@outlook.com>
> 
> We already have MODULE_DEVICE_TABLE(), so this MODULE_ALIAS() has no use
> and should be removed.
> 

That's not accurate. You don't have for platform IDs, so you basically
remove ability to autoload via platform. It's fine for me, but the
commit msg is just misleading.


Best regards,
Krzysztof
Yang Xiwen March 5, 2024, 6:51 a.m. UTC | #2 
On 3/1/2024 2:50 PM, Krzysztof Kozlowski wrote:
> On 01/03/2024 04:36, Yang Xiwen via B4 Relay wrote:
>> From: Yang Xiwen <forbidden405@outlook.com>
>>
>> We already have MODULE_DEVICE_TABLE(), so this MODULE_ALIAS() has no use
>> and should be removed.
>>
> That's not accurate. You don't have for platform IDs, so you basically
> remove ability to autoload via platform. It's fine for me, but the
> commit msg is just misleading.


I've never heard of any distro making use of this custom alias. A 
generic OF based module alias is enough.


>
>
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c
index 22a4697e0dde..2ecc10a9ca28 100644
--- a/drivers/net/ethernet/hisilicon/hisi_femac.c
+++ b/drivers/net/ethernet/hisilicon/hisi_femac.c
@@ -1014,4 +1014,3 @@  module_platform_driver(hisi_femac_driver);
 MODULE_DESCRIPTION("Hisilicon Fast Ethernet MAC driver");
 MODULE_AUTHOR("Dongpo Li <lidongpo@hisilicon.com>");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("platform:hisi-femac");