diff mbox series

[net-next] net/nlmon: Cancel setting filelds of statistics to zero.

Message ID 20240302105224.GA7223@didi-ThinkCentre-M920t-N000 (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series [net-next] net/nlmon: Cancel setting filelds of statistics to zero. | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 940 this patch: 940
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 4 of 4 maintainers
netdev/build_clang success Errors and warnings before: 956 this patch: 956
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 956 this patch: 956
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 10 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

fuyuanli March 2, 2024, 10:52 a.m. UTC
Since filelds of rtnl_link_stats64 have been set to zero in previous
dev_get_stats function, there is no need to set again in ndo_get_stats64
function.

Signed-off-by: fuyuanli <fuyuanli@didiglobal.com>
---
 drivers/net/nlmon.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Jakub Kicinski March 3, 2024, 3:45 a.m. UTC | #1
On Sat, 2 Mar 2024 18:52:24 +0800 fuyuanli wrote:
> Since filelds of rtnl_link_stats64 have been set to zero in previous
> dev_get_stats function, there is no need to set again in ndo_get_stats64
> function.

Please spellcheck the commit msg.
diff mbox series

Patch

diff --git a/drivers/net/nlmon.c b/drivers/net/nlmon.c
index 5e19a6839dea..9b205b152734 100644
--- a/drivers/net/nlmon.c
+++ b/drivers/net/nlmon.c
@@ -56,10 +56,8 @@  nlmon_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
 	dev_lstats_read(dev, &packets, &bytes);
 
 	stats->rx_packets = packets;
-	stats->tx_packets = 0;
 
 	stats->rx_bytes = bytes;
-	stats->tx_bytes = 0;
 }
 
 static u32 always_on(struct net_device *dev)