| Message ID | 20240305051328.806892-3-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1d8617b2a610f36e361a91846725c065dc233541 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | tools: ynl: clean up make clean | expand |
Jakub Kicinski <kuba@kernel.org> writes: > Donald points out most YNL makefiles are missing distclean > in .PHONY, even tho generated/Makefile does list it. > > Suggested-by: Donald Hunter <donald.hunter@gmail.com> > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
diff --git a/tools/net/ynl/Makefile b/tools/net/ynl/Makefile index 1874296665e1..8e9e09d84e26 100644 --- a/tools/net/ynl/Makefile +++ b/tools/net/ynl/Makefile @@ -18,4 +18,4 @@ samples: | lib generated fi \ done -.PHONY: clean all $(SUBDIRS) +.PHONY: all clean distclean $(SUBDIRS) diff --git a/tools/net/ynl/lib/Makefile b/tools/net/ynl/lib/Makefile index 2201dafc62b3..1507833d05c5 100644 --- a/tools/net/ynl/lib/Makefile +++ b/tools/net/ynl/lib/Makefile @@ -24,5 +24,5 @@ distclean: clean %.o: %.c $(COMPILE.c) -MMD -c -o $@ $< -.PHONY: all clean +.PHONY: all clean distclean .DEFAULT_GOAL=all diff --git a/tools/net/ynl/samples/Makefile b/tools/net/ynl/samples/Makefile index 3e81432f7b27..e194a7565861 100644 --- a/tools/net/ynl/samples/Makefile +++ b/tools/net/ynl/samples/Makefile @@ -31,5 +31,5 @@ $(BINS): ../lib/ynl.a ../generated/protos.a $(SRCS) distclean: clean rm -f $(BINS) -.PHONY: all clean +.PHONY: all clean distclean .DEFAULT_GOAL=all
Donald points out most YNL makefiles are missing distclean in .PHONY, even tho generated/Makefile does list it. Suggested-by: Donald Hunter <donald.hunter@gmail.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- v2: new patch --- tools/net/ynl/Makefile | 2 +- tools/net/ynl/lib/Makefile | 2 +- tools/net/ynl/samples/Makefile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)