| Message ID | 20240305121524.2254533-2-leitao@debian.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 13957a0b070831f287eb5a52c14e9f40d4e94750 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/3] net: gtp: Leverage core stats allocator | expand |
On Tue, Mar 05, 2024 at 04:15:22AM -0800, Breno Leitao wrote: > Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is > configured") moved the callback to dev_get_tstats64() to net core, so, > unless the driver is doing some custom stats collection, it does not > need to set .ndo_get_stats64. > > Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it > doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 > function pointer. > > Signed-off-by: Breno Leitao <leitao@debian.org> Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index facbfba5d77f..a279f0cd1b4d 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -940,7 +940,6 @@ static const struct net_device_ops gtp_netdev_ops = { .ndo_init = gtp_dev_init, .ndo_uninit = gtp_dev_uninit, .ndo_start_xmit = gtp_dev_xmit, - .ndo_get_stats64 = dev_get_tstats64, }; static const struct device_type gtp_type = {
Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is configured") moved the callback to dev_get_tstats64() to net core, so, unless the driver is doing some custom stats collection, it does not need to set .ndo_get_stats64. Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Signed-off-by: Breno Leitao <leitao@debian.org> --- drivers/net/gtp.c | 1 - 1 file changed, 1 deletion(-)