| Message ID | 20240306085017.21731-6-Parthiban.Veerasooran@microchip.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface | expand |
On Wed, Mar 06, 2024 at 02:20:10PM +0530, Parthiban Veerasooran wrote: > This will unmask the following error interrupts from the MAC-PHY. > tx protocol error > rx buffer overflow error > loss of frame error The standard seems to call it "Loss of framing". To me as a network person, a frame is an L2 Ethernet packet. However, framing is something completely different, being able to synchronise a bitstream with some sort of markers, e.g. E1 to know where the 32 slots are. In this context, we are not talking about packets, but the SPI bit stream. So it would be good to use framing, not frame. Andrew
Hi Andrew, On 07/03/24 6:13 am, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Wed, Mar 06, 2024 at 02:20:10PM +0530, Parthiban Veerasooran wrote: >> This will unmask the following error interrupts from the MAC-PHY. >> tx protocol error >> rx buffer overflow error >> loss of frame error > > The standard seems to call it "Loss of framing". To me as a network > person, a frame is an L2 Ethernet packet. However, framing is > something completely different, being able to synchronise a bitstream > with some sort of markers, e.g. E1 to know where the 32 slots are. > > In this context, we are not talking about packets, but the SPI bit > stream. So it would be good to use framing, not frame. Yes you are right. The specification also says the same thing as you said "Loss of Framing Error". I will correct it in the next version. Best regards, Parthiban V > > Andrew >
diff --git a/drivers/net/ethernet/oa_tc6.c b/drivers/net/ethernet/oa_tc6.c index e9ddc4ff7d0d..f8593b793291 100644 --- a/drivers/net/ethernet/oa_tc6.c +++ b/drivers/net/ethernet/oa_tc6.c @@ -18,6 +18,13 @@ #define OA_TC6_REG_STATUS0 0x0008 #define STATUS0_RESETC BIT(6) /* Reset Complete */ +/* Interrupt Mask Register #0 */ +#define OA_TC6_REG_INT_MASK0 0x000C +#define INT_MASK0_HEADER_ERR_MASK BIT(5) +#define INT_MASK0_LOSS_OF_FRAME_ERR_MASK BIT(4) +#define INT_MASK0_RX_BUFFER_OVERFLOW_ERR_MASK BIT(3) +#define INT_MASK0_TX_PROTOCOL_ERR_MASK BIT(0) + /* Control command header */ #define OA_TC6_CTRL_HEADER_DATA_NOT_CTRL BIT(31) #define OA_TC6_CTRL_HEADER_WRITE BIT(29) @@ -324,6 +331,23 @@ static int oa_tc6_sw_reset_macphy(struct oa_tc6 *tc6) return oa_tc6_write_register(tc6, OA_TC6_REG_STATUS0, regval); } +static int oa_tc6_unmask_macphy_error_interrupts(struct oa_tc6 *tc6) +{ + u32 regval; + int ret; + + ret = oa_tc6_read_register(tc6, OA_TC6_REG_INT_MASK0, ®val); + if (ret) + return ret; + + regval &= ~(INT_MASK0_TX_PROTOCOL_ERR_MASK | + INT_MASK0_RX_BUFFER_OVERFLOW_ERR_MASK | + INT_MASK0_LOSS_OF_FRAME_ERR_MASK | + INT_MASK0_HEADER_ERR_MASK); + + return oa_tc6_write_register(tc6, OA_TC6_REG_INT_MASK0, regval); +} + /** * oa_tc6_init - allocates and initializes oa_tc6 structure. * @spi: device with which data will be exchanged. @@ -364,6 +388,13 @@ struct oa_tc6 *oa_tc6_init(struct spi_device *spi) return NULL; } + ret = oa_tc6_unmask_macphy_error_interrupts(tc6); + if (ret) { + dev_err(&tc6->spi->dev, + "MAC-PHY error interrupts unmask failed: %d\n", ret); + return NULL; + } + return tc6; } EXPORT_SYMBOL_GPL(oa_tc6_init);
This will unmask the following error interrupts from the MAC-PHY. tx protocol error rx buffer overflow error loss of frame error header error The MAC-PHY will signal an error by setting the EXST bit in the receive data footer which will then allow the host to read the STATUS0 register find the source of the error. Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> --- drivers/net/ethernet/oa_tc6.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)