From patchwork Fri Mar 8 08:39:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Xiwen via B4 Relay X-Patchwork-Id: 13586543 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5CE437171; Fri, 8 Mar 2024 08:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709887185; cv=none; b=f94g8S7lEyg98cGTHFGCNmQx8Jv1CiEpyTP7OOhBeXXG6cn/wNaaKKdSNcacw+ulsBJruHVXxy27sa5SPaMcftSmg61fQLplt4JsPQmTWTAxJvKT7DKd/YFxhOpDaXAmPMvHslE0a3gHghjaOug06wejh1WKCAqReXJWU92stCU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709887185; c=relaxed/simple; bh=vu47BKfN+xFcRDfbkn3C1v8zrm2ugq1RBZELrpt63GU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iXMT+lYsGK1hFgGA8QIKgcs3zWmM+8pArZmhQnN8vMY3aPgfdGWwx1x8cYJCo3tSXrq8gTQuDz7q7wczt1JbMsUn2YJga8QtXJNs93Kohl6FmeDMGY4uWHHH+k8b73ff87ozSxuT82hNuX/1BtzjvUs4Zv1dZKEYXG0IL3+iOkk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XowZlo8C; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XowZlo8C" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4B0E0C433B2; Fri, 8 Mar 2024 08:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709887185; bh=vu47BKfN+xFcRDfbkn3C1v8zrm2ugq1RBZELrpt63GU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=XowZlo8CI5jsvJyhMHHI2i9sR5ERwgD1kwsyf1qwqoZ+EPj0YpUpI5384B2F0yeE2 ryrdtc/SbVlQX3n0yGRt3IkRxSAomFMU58uT+0UySnTK1iz4AQ0MVfTgpHtaJEoaSA vI4v2iQ7QLnreMgqGfNiOpQgylatMnINY4BD7YfyGsgvX90bJqwCSrv0jVw3yFrWbC 7hEE34ZHm8zcx0reqUrEHCusncfisxNWx/2ahufKIPpt8FtYZ6rEvT8a8FrbSz5b0K 7G0Va8bfxHhEyzQmWK5JEt4J9ojjMNa5I7x/ilLngf/DUR3YwFMd0HUo4Zxkh0pZSu FBoX1VMaeaorA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A445C5475B; Fri, 8 Mar 2024 08:39:45 +0000 (UTC) From: Yang Xiwen via B4 Relay Date: Fri, 08 Mar 2024 16:39:45 +0800 Subject: [PATCH net-next v10 3/8] net: mdio: hisi-femac: remove clock Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240308-net-v10-3-3684df40897e@outlook.com> References: <20240308-net-v10-0-3684df40897e@outlook.com> In-Reply-To: <20240308-net-v10-0-3684df40897e@outlook.com> To: Yisen Zhuang , Salil Mehta , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Heiner Kallweit , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Yang Xiwen X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1709887184; l=1802; i=forbidden405@outlook.com; s=20230724; h=from:subject:message-id; bh=kdWAr70dNlF5sryokQxZlrJGOk8Z9nw7ekwi0I/9miA=; b=SRw4iDjeFk1T6mGcCf8t/M0b4JZS0PffrYMwlRpgm50Cns3b/2wbnL4UCz3tCKA9UkxqTnSRP DI0hUoez7WzBuINuHlqtzA6orzNVzlY7xGwrlno/BwpW0p3Nl4orl8p X-Developer-Key: i=forbidden405@outlook.com; a=ed25519; pk=qOD5jhp891/Xzc+H/PZ8LWVSWE3O/XCQnAg+5vdU2IU= X-Endpoint-Received: by B4 Relay for forbidden405@outlook.com/20230724 with auth_id=67 X-Original-From: Yang Xiwen Reply-To: X-Patchwork-Delegate: kuba@kernel.org From: Yang Xiwen This integrated MDIO bus does not have a dedicated clock, remove it. Signed-off-by: Yang Xiwen --- drivers/net/mdio/mdio-hisi-femac.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/net/mdio/mdio-hisi-femac.c b/drivers/net/mdio/mdio-hisi-femac.c index 6703f626ee83..faf4688eb1ab 100644 --- a/drivers/net/mdio/mdio-hisi-femac.c +++ b/drivers/net/mdio/mdio-hisi-femac.c @@ -5,7 +5,6 @@ * Copyright (c) 2016 HiSilicon Technologies Co., Ltd. */ -#include #include #include #include @@ -21,7 +20,6 @@ #define BIT_WR_DATA_OFFSET 16 struct hisi_femac_mdio_data { - struct clk *clk; void __iomem *membase; }; @@ -93,26 +91,14 @@ static int hisi_femac_mdio_probe(struct platform_device *pdev) goto err_out_free_mdiobus; } - data->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(data->clk)) { - ret = PTR_ERR(data->clk); - goto err_out_free_mdiobus; - } - - ret = clk_prepare_enable(data->clk); - if (ret) - goto err_out_free_mdiobus; - ret = of_mdiobus_register(bus, np); if (ret) - goto err_out_disable_clk; + goto err_out_free_mdiobus; platform_set_drvdata(pdev, bus); return 0; -err_out_disable_clk: - clk_disable_unprepare(data->clk); err_out_free_mdiobus: mdiobus_free(bus); return ret; @@ -121,10 +107,8 @@ static int hisi_femac_mdio_probe(struct platform_device *pdev) static void hisi_femac_mdio_remove(struct platform_device *pdev) { struct mii_bus *bus = platform_get_drvdata(pdev); - struct hisi_femac_mdio_data *data = bus->priv; mdiobus_unregister(bus); - clk_disable_unprepare(data->clk); mdiobus_free(bus); }