| Message ID | 20240313153437.124749-1-m.lobanov@rosalinux.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 237bb5f7f7f55ec5f773469a974c61a49c298625 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | cxgb4: unnecessary check for 0 in the free_sge_txq_uld() function | expand |
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Wed, 13 Mar 2024 11:34:36 -0400 you wrote: > The free_sge_txq_old() function has an unnecessary txq check of 0. > This check is not necessary, since the txq pointer is initialized by the > uldtxq[i] address from the operation &txq_info->uldtxq[i], which ensures > that txq is not equal to 0. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > [...] Here is the summary with links: - cxgb4: unnecessary check for 0 in the free_sge_txq_uld() function https://git.kernel.org/netdev/net-next/c/237bb5f7f7f5 You are awesome, thank you!
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c index 17faac715882..5c13bcb4550d 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c @@ -406,7 +406,7 @@ free_sge_txq_uld(struct adapter *adap, struct sge_uld_txq_info *txq_info) for (i = 0; i < nq; i++) { struct sge_uld_txq *txq = &txq_info->uldtxq[i]; - if (txq && txq->q.desc) { + if (txq->q.desc) { tasklet_kill(&txq->qresume_tsk); t4_ofld_eq_free(adap, adap->mbox, adap->pf, 0, txq->q.cntxt_id);
The free_sge_txq_old() function has an unnecessary txq check of 0. This check is not necessary, since the txq pointer is initialized by the uldtxq[i] address from the operation &txq_info->uldtxq[i], which ensures that txq is not equal to 0. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: ab677ff4ad15 ("cxgb4: Allocate Tx queues dynamically") Signed-off-by: Mikhail Lobanov <m.lobanov@rosalinux.ru> --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)