diff mbox series

[v2,4/5] net: marvell: prestera: force good base mac

Message ID 20240320172008.2989693-5-enachman@marvell.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series Fix prestera driver fail to probe twice | expand

Checks

Context Check Description
netdev/series_format warning Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 939 this patch: 939
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers fail 2 blamed authors not CCed: volodymyr.mytnyk@plvision.eu oleksandr.mazur@plvision.eu; 2 maintainers not CCed: volodymyr.mytnyk@plvision.eu oleksandr.mazur@plvision.eu
netdev/build_clang success Errors and warnings before: 956 this patch: 956
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 956 this patch: 956
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest fail net-next-2024-03-20--18-00 (tests: 895)

Commit Message

Elad Nachman March 20, 2024, 5:20 p.m. UTC 
From: Elad Nachman <enachman@marvell.com>

The switching ASIC router HW unit MAC Source Address is configured with
40-bits of MAC base address in its registers (done in the firmware code),
requiring all ports doing L3 routing in HW to have the same upper 40-bit
MAC address.

Since each switchport MAC address uses the switch base mac address and
then adds the physical port number to it, Force the last byte of the
switch base mac address to be at most 127, so when adding to it, we
will not wrap around the previous (more significant) mac address byte,
resulting in a warning message.

Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
Signed-off-by: Elad Nachman <enachman@marvell.com>
---
 drivers/net/ethernet/marvell/prestera/prestera_main.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andrew Lunn March 21, 2024, 12:13 a.m. UTC | #1 
On Wed, Mar 20, 2024 at 07:20:07PM +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
> 
> The switching ASIC router HW unit MAC Source Address is configured with
> 40-bits of MAC base address in its registers (done in the firmware code),
> requiring all ports doing L3 routing in HW to have the same upper 40-bit
> MAC address.
> 
> Since each switchport MAC address uses the switch base mac address and
> then adds the physical port number to it, Force the last byte of the
> switch base mac address to be at most 127, so when adding to it, we
> will not wrap around the previous (more significant) mac address byte,
> resulting in a warning message.
> 
> Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
> Signed-off-by: Elad Nachman <enachman@marvell.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
diff mbox series

Patch

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index bcaa8ea27b49..87d8fc4162b3 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -860,6 +860,7 @@  static int prestera_switch_set_base_mac_addr(struct prestera_switch *sw)
 		ret = of_get_mac_address(sw->np, sw->base_mac);
 	if (!is_valid_ether_addr(sw->base_mac) || ret) {
 		eth_random_addr(sw->base_mac);
+		sw->base_mac[5] &= 0x7f;
 		dev_info(prestera_dev(sw), "using random base mac address\n");
 	}