| Message ID | 20240322072456.1251387-1-gaoxingwang1@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Michal Kubecek |
| Headers | show |
| Series | netlink: fix typo | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Fri, Mar 22, 2024 at 3:26 PM gaoxingwang <gaoxingwang1@huawei.com> wrote: > > Add missing colon in coalesce_reply_cb > > Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params) This commit cannot be found in net/net-next tree... > Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com> > > Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com> nit: two duplicated SoB > --- > netlink/coalesce.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/netlink/coalesce.c b/netlink/coalesce.c > index bc34d3d..bb93f9b 100644 > --- a/netlink/coalesce.c > +++ b/netlink/coalesce.c Where is this file? I suspect you're not using the standard mainline? > @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data) > tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]); > show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t", > tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]); > - show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t", > + show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t", > tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]); > show_cr(); > > -- > 2.27.0 > >
Fri, Mar 22, 2024 at 08:24:56AM CET, gaoxingwang1@huawei.com wrote: >Add missing colon in coalesce_reply_cb > >Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params) >Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com> > >Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com> >--- > netlink/coalesce.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/netlink/coalesce.c b/netlink/coalesce.c >index bc34d3d..bb93f9b 100644 >--- a/netlink/coalesce.c >+++ b/netlink/coalesce.c Please make clear indication which project/tree you target with your patch by putting appropriate name in the [patch NAME] brackets >@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data) > tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]); > show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t", > tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]); >- show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t", >+ show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t", > tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]); > show_cr(); > >-- >2.27.0 > >
Fri, Mar 22, 2024 at 08:24:56AM CET, gaoxingwang1@huawei.com wrote: >Add missing colon in coalesce_reply_cb > >Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params) >Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com> > >Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com> Also, please make sure your name is properly formatted. "gaoxingwang" certainly is not. >--- > netlink/coalesce.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/netlink/coalesce.c b/netlink/coalesce.c >index bc34d3d..bb93f9b 100644 >--- a/netlink/coalesce.c >+++ b/netlink/coalesce.c >@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data) > tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]); > show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t", > tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]); >- show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t", >+ show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t", > tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]); > show_cr(); > >-- >2.27.0 > >
On Fri, Mar 22, 2024 at 09:13:53AM +0100, Jiri Pirko wrote: > Please make clear indication which project/tree you target with your > patch by putting appropriate name in the [patch NAME] brackets In this case, it should be "[PATCH ethtool]". Michal
On Fri, 22 Mar 2024 09:14:39 +0100 Jiri Pirko wrote:
> "gaoxingwang" certainly is not.
According to what rules? Honest question, I don't know much about
transliteration of what I guess is a Chinese name.
>> Please make clear indication which project/tree you target with your >> patch by putting appropriate name in the [patch NAME] brackets > >In this case, it should be "[PATCH ethtool]". > >Michal Yes, this is a commit for the ethtool project. First time contributing a patch to this project, not familiar with it yet. Thank you all or your guidance. I'll resubmit the patch later.
Fri, Mar 22, 2024 at 04:07:27PM CET, kuba@kernel.org wrote: >On Fri, 22 Mar 2024 09:14:39 +0100 Jiri Pirko wrote: >> "gaoxingwang" certainly is not. > >According to what rules? Honest question, I don't know much about >transliteration of what I guess is a Chinese name. At least capital letter would be nice :) But "Wang" looks like a surname and therefore a space would be appropriate too.
diff --git a/netlink/coalesce.c b/netlink/coalesce.c index bc34d3d..bb93f9b 100644 --- a/netlink/coalesce.c +++ b/netlink/coalesce.c @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data) tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]); show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t", tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]); - show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t", + show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t", tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]); show_cr();