| Message ID | 20240326061233.4133148-1-suhui@nfschina.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2,1/2] octeontx2-pf: check negative error code in otx2_open() | expand |
On Tue, Mar 26, 2024 at 02:12:34PM +0800, Su Hui wrote: > otx2_rxtx_enable() return negative error code such as -EIO, > check -EIO rather than EIO to fix this problem. > > Fixes: c926252205c4 ("octeontx2-pf: Disable packet I/O for graceful exit") > Signed-off-by: Su Hui <suhui@nfschina.com> > Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com> Reviewed-by: Simon Horman <horms@kernel.org>
On Tue, Mar 26, 2024 at 11:43 AM Su Hui <suhui@nfschina.com> wrote: > > otx2_rxtx_enable() return negative error code such as -EIO, > check -EIO rather than EIO to fix this problem. > > Fixes: c926252205c4 ("octeontx2-pf: Disable packet I/O for graceful exit") > Signed-off-by: Su Hui <suhui@nfschina.com> > Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com> > --- LGTM Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> > v2: add "net" in subject > drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c > index b40bd0e46751..3f46d5e0fb2e 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c > @@ -1933,7 +1933,7 @@ int otx2_open(struct net_device *netdev) > * mcam entries are enabled to receive the packets. Hence disable the > * packet I/O. > */ > - if (err == EIO) > + if (err == -EIO) > goto err_disable_rxtx; > else if (err) > goto err_tx_stop_queues; > -- > 2.30.2 > >
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c index b40bd0e46751..3f46d5e0fb2e 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c @@ -1933,7 +1933,7 @@ int otx2_open(struct net_device *netdev) * mcam entries are enabled to receive the packets. Hence disable the * packet I/O. */ - if (err == EIO) + if (err == -EIO) goto err_disable_rxtx; else if (err) goto err_tx_stop_queues;
otx2_rxtx_enable() return negative error code such as -EIO, check -EIO rather than EIO to fix this problem. Fixes: c926252205c4 ("octeontx2-pf: Disable packet I/O for graceful exit") Signed-off-by: Su Hui <suhui@nfschina.com> Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com> --- v2: add "net" in subject drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)