| Message ID | 20240326163107.306612-1-jtornosm@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,1/2] net: usb: ax88179_178a: avoid the interface always configured as random address | expand |
On Tue, Mar 26, 2024 at 05:31:07PM +0100, Jose Ignacio Tornos Martinez wrote: > If the mac address can not be read from the device registers or the > devicetree, a random address is generated, but this was already done from > usbnet_probe, so it is not necessary to call eth_hw_addr_random from here > again to generate another random address. > > Indeed, when reset was also executed from bind, generate another random mac > address invalidated the check from usbnet_probe to configure if the assigned > mac address for the interface was random or not, because it is comparing > with the initial generated random address. Now, with only a reset from open > operation, it is just a harmless simplification. > > cc: stable@vger.kernel.org # 6.6+ > Fixes: 9fb137aef34e ("net: usb: ax88179_178a: allow optionally getting mac address from device tree") > Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com> > --- > V1 -> V2: > - Split the fix and the improvement in two patches and keep curly-brackets > as Simon Horman suggests. Hi Jose, Thanks for splitting the patches. They look good, but there are a few process issues. Sorry for not being clearer in my previous email. As the 2nd patch of the series is not a fix it: - Should not have a fixes tag - Should not be sent to stable - Should be targeted at the net-next tree rather than the net tree As the granularity of patch handling on netdev is generally at the patchset level I believe that this means that you need to separately, in different, new, email threads, repost: 1. Patch 1/2 of this series, targeted at net, with a Fixes tag [PATCH net v3] net: usb: ax88179_178a: avoid the interface always configured as random address 2. Patch 2/2 of this series, targeted at net-next, without a Fixes tag [PATCH net-next v3] et: usb: ax88179_178a: non necessary second random mac address Also, please be sure to wait 24 hours since the posting of this patch-set before reposting. Some more information can be found here: https://docs.kernel.org/process/maintainer-netdev.html ... -- pw-bot: changes-requested
Hello Simon, Returning after Easter. I'm sorry I didn't understand you, I have to learn more about the procedure. I hope to do it better now. Thanks for your help Best regards José Ignacio
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 8ca8ace93d9c..08c9b2ab9711 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1276,7 +1276,6 @@ static void ax88179_get_mac_addr(struct usbnet *dev) dev->net->addr_assign_type = NET_ADDR_PERM; } else { netdev_info(dev->net, "invalid MAC address, using random\n"); - eth_hw_addr_random(dev->net); } ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN,
If the mac address can not be read from the device registers or the devicetree, a random address is generated, but this was already done from usbnet_probe, so it is not necessary to call eth_hw_addr_random from here again to generate another random address. Indeed, when reset was also executed from bind, generate another random mac address invalidated the check from usbnet_probe to configure if the assigned mac address for the interface was random or not, because it is comparing with the initial generated random address. Now, with only a reset from open operation, it is just a harmless simplification. cc: stable@vger.kernel.org # 6.6+ Fixes: 9fb137aef34e ("net: usb: ax88179_178a: allow optionally getting mac address from device tree") Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com> --- V1 -> V2: - Split the fix and the improvement in two patches and keep curly-brackets as Simon Horman suggests. drivers/net/usb/ax88179_178a.c | 1 - 1 file changed, 1 deletion(-)