| Message ID | 20240326223825.4084412-5-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b324a960354b872431d25959ad384ab66a7116ec |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | enabled -Wformat-truncation for clang | expand |
Hi, >-----Original Message----- >From: Arnd Bergmann <arnd@kernel.org> >Sent: Wednesday, March 27, 2024 4:08 AM >To: llvm@lists.linux.dev; Saeed Mahameed <saeedm@nvidia.com>; Leon >Romanovsky <leon@kernel.org> >Cc: Arnd Bergmann <arnd@arndb.de>; David S. Miller <davem@davemloft.net>; >Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo >Abeni <pabeni@redhat.com>; Nathan Chancellor <nathan@kernel.org>; Nick >Desaulniers <ndesaulniers@google.com>; Bill Wendling <morbo@google.com>; >Justin Stitt <justinstitt@google.com>; Vlad Buslov <vladbu@nvidia.com>; Roi >Dayan <roid@nvidia.com>; Maor Dickman <maord@nvidia.com>; Gal Pressman ><gal@nvidia.com>; netdev@vger.kernel.org; linux-rdma@vger.kernel.org; linux- >kernel@vger.kernel.org >Subject: [PATCH 4/9] mlx5: avoid truncating error message > >From: Arnd Bergmann <arnd@arndb.de> > >clang warns that one error message is too long for its destination buffer: > >drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c:1876:4: error: 'snprintf' >will always be truncated; specified size is 80, but format string expands to at least >94 [-Werror,-Wformat-truncation-non-kprintf] > >Reword it to be a bit shorter so it always fits. > >Fixes: 70f0302b3f20 ("net/mlx5: Bridge, implement mdb offload") >Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com> Thanks, Sundeep >--- > drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c >b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c >index 1b9bc32efd6f..c5ea1d1d2b03 100644 >--- a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c >+++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c >@@ -1874,7 +1874,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device >*dev, u16 vport_num, u16 esw_ > "Failed to lookup bridge port vlan metadata to >create MDB (MAC=%pM,vid=%u,vport=%u)\n", > addr, vid, vport_num); > NL_SET_ERR_MSG_FMT_MOD(extack, >- "Failed to lookup bridge port vlan >metadata to create MDB (MAC=%pM,vid=%u,vport=%u)\n", >+ "Failed to lookup vlan metadata for >MDB (MAC=%pM,vid=%u,vport=%u)\n", > addr, vid, vport_num); > return -EINVAL; > } >-- >2.39.2 >
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c index 1b9bc32efd6f..c5ea1d1d2b03 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c @@ -1874,7 +1874,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device *dev, u16 vport_num, u16 esw_ "Failed to lookup bridge port vlan metadata to create MDB (MAC=%pM,vid=%u,vport=%u)\n", addr, vid, vport_num); NL_SET_ERR_MSG_FMT_MOD(extack, - "Failed to lookup bridge port vlan metadata to create MDB (MAC=%pM,vid=%u,vport=%u)\n", + "Failed to lookup vlan metadata for MDB (MAC=%pM,vid=%u,vport=%u)\n", addr, vid, vport_num); return -EINVAL; }