| Message ID | 20240328020620.4054692-1-suhui@nfschina.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e709acbd84fb6ef32736331b0147f027a3ef4c20 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v3] octeontx2-pf: check negative error code in otx2_open() | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 28 Mar 2024 10:06:21 +0800 you wrote: > otx2_rxtx_enable() return negative error code such as -EIO, > check -EIO rather than EIO to fix this problem. > > Fixes: c926252205c4 ("octeontx2-pf: Disable packet I/O for graceful exit") > Signed-off-by: Su Hui <suhui@nfschina.com> > Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com> > Reviewed-by: Simon Horman <horms@kernel.org> > Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> > > [...] Here is the summary with links: - [net,v3] octeontx2-pf: check negative error code in otx2_open() https://git.kernel.org/netdev/net/c/e709acbd84fb You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c index b40bd0e46751..3f46d5e0fb2e 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c @@ -1933,7 +1933,7 @@ int otx2_open(struct net_device *netdev) * mcam entries are enabled to receive the packets. Hence disable the * packet I/O. */ - if (err == EIO) + if (err == -EIO) goto err_disable_rxtx; else if (err) goto err_tx_stop_queues;
otx2_rxtx_enable() return negative error code such as -EIO, check -EIO rather than EIO to fix this problem. Fixes: c926252205c4 ("octeontx2-pf: Disable packet I/O for graceful exit") Signed-off-by: Su Hui <suhui@nfschina.com> Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com> Reviewed-by: Simon Horman <horms@kernel.org> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> --- v3: - split the v2 patchset into individual patches v2: - add "net" in subject drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)