diff mbox series

[1/2] wifi: mac80211: remove ieee80211_set_hw_80211_encap()

Message ID 20240329-mac80211-kdoc-retval-v1-1-5e4d1ad6c250@quicinc.com (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series wifi: mac80211: Fix mac80211.h kernel-doc issues | expand

Checks

Context Check Description
netdev/series_format warning Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 978 this patch: 978
netdev/build_tools success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 954 this patch: 954
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 990 this patch: 990
netdev/checkpatch warning WARNING: 'rmeoved' may be misspelled - perhaps 'removed'?
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Jeff Johnson March 29, 2024, 8:27 p.m. UTC
While fixing kernel-doc issues it was discovered that the
ieee80211_set_hw_80211_encap() prototype doesn't actually have an
implementation, so remove it.

Note the implementation was rmeoved in patch 6aea26ce5a4c ("mac80211:
rework tx encapsulation offload API").

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 include/net/mac80211.h | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Randy Dunlap March 30, 2024, 4:20 p.m. UTC | #1
On 3/29/24 13:27, Jeff Johnson wrote:
> While fixing kernel-doc issues it was discovered that the
> ieee80211_set_hw_80211_encap() prototype doesn't actually have an
> implementation, so remove it.
> 
> Note the implementation was rmeoved in patch 6aea26ce5a4c ("mac80211:
> rework tx encapsulation offload API").
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  include/net/mac80211.h | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index 353488ab94a2..e6a11a982ca8 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -7478,18 +7478,6 @@ u32 ieee80211_calc_rx_airtime(struct ieee80211_hw *hw,
>  u32 ieee80211_calc_tx_airtime(struct ieee80211_hw *hw,
>  			      struct ieee80211_tx_info *info,
>  			      int len);
> -/**
> - * ieee80211_set_hw_80211_encap - enable hardware encapsulation offloading.
> - *
> - * This function is used to notify mac80211 that a vif can be passed raw 802.3
> - * frames. The driver needs to then handle the 802.11 encapsulation inside the
> - * hardware or firmware.
> - *
> - * @vif: &struct ieee80211_vif pointer from the add_interface callback.
> - * @enable: indicate if the feature should be turned on or off
> - */
> -bool ieee80211_set_hw_80211_encap(struct ieee80211_vif *vif, bool enable);
> -
>  /**
>   * ieee80211_get_fils_discovery_tmpl - Get FILS discovery template.
>   * @hw: pointer obtained from ieee80211_alloc_hw().
>
diff mbox series

Patch

diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index 353488ab94a2..e6a11a982ca8 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -7478,18 +7478,6 @@  u32 ieee80211_calc_rx_airtime(struct ieee80211_hw *hw,
 u32 ieee80211_calc_tx_airtime(struct ieee80211_hw *hw,
 			      struct ieee80211_tx_info *info,
 			      int len);
-/**
- * ieee80211_set_hw_80211_encap - enable hardware encapsulation offloading.
- *
- * This function is used to notify mac80211 that a vif can be passed raw 802.3
- * frames. The driver needs to then handle the 802.11 encapsulation inside the
- * hardware or firmware.
- *
- * @vif: &struct ieee80211_vif pointer from the add_interface callback.
- * @enable: indicate if the feature should be turned on or off
- */
-bool ieee80211_set_hw_80211_encap(struct ieee80211_vif *vif, bool enable);
-
 /**
  * ieee80211_get_fils_discovery_tmpl - Get FILS discovery template.
  * @hw: pointer obtained from ieee80211_alloc_hw().