From patchwork Mon Apr 1 03:57:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Chebbi X-Patchwork-Id: 13612513 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E723B5382 for ; Mon, 1 Apr 2024 03:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711943706; cv=none; b=eDLjO0LZOypmxlvsngpWTCR+V76eaOOPQRiH0Kp07vGyLFH+d0W4ywyZY3CNtkBBhaKub3mxLm4sElzBgvJgsdtz/A1wtUXAESuxeT6COgHTDF5x3k/ltOC8j2DQeKXYmRruP04i98VWwqo5hprkNAnfrpRnTAZkUiPTGif9V1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711943706; c=relaxed/simple; bh=Sw0+7BLxyfE/cxFpUiyXsg+I3/tE2uw/nrEBopyVHY0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=jtW+FfdCiQN+9WMHb6qofdmMtbU1Lk+8ylfYiE6A8Bc/MwqZ4cIFbX9vl4dT4mud9t2hgIgxahEQkEgUrvUmKBKi5shgZ9JhU93qLcQMPy1JBRyfmx44O/R1VAynScUpwrRdu1ZSd5k08UP2w4XOLO4Uw0NAf0REmd/NKaXR8bo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Ksr9vbM4; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Ksr9vbM4" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3c3e2e18db7so2458464b6e.0 for ; Sun, 31 Mar 2024 20:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1711943704; x=1712548504; darn=vger.kernel.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=UImoD6jWbwESHi15bSVpmYLawqoHbLGC4bQ9Z6wY4go=; b=Ksr9vbM4fKNS+3M34fWUK7fQuGRQC4ZMBhR8vfqbvqPzOsKETggorr6D6gZy4ZvIe8 QVZKyIQadvPlFbeXKuRFHOrkAazmx8eLl/JCZVeEIn0huHHqtcU7TXLPhvSHW34or5X1 5jPcVwwmlzeOOK0T50aNitncxfo5xJFbGED3o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711943704; x=1712548504; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UImoD6jWbwESHi15bSVpmYLawqoHbLGC4bQ9Z6wY4go=; b=WOIc+X+oxYT/PXJ70FM5xgIps1AwH31WFGwTt7Zg7Uw3Dt41zn3Y3zY1IDAeq+KNxo YhMwLAkTzehbWmkBwIw6MTxS0tXNBIP3M3rACUnfJSrqBHhgvKPZohjB4hp5BPM/mYVi 7jk/snU86LZf7fLcrzi5JQ6r3QNmLzHwkVl93ea2mOULfL/lK4/VdooRv15/pDQy9EJb sIi4pTBwvrTFZ3SU5trxMhzFo7bHrxGoGXQx1Rh4wGDT2FqdwVF37OuPgYZleWYOTLTA OklYqvsTlTmHQwPZKuF4qQBJpHfkEDEV8sM5lj+DbZsdkYWlJmWj2qkcLvPtReaK8Dqe RMJQ== X-Forwarded-Encrypted: i=1; AJvYcCXzQYzks5PxZfIhIqrOhPldnAdeU3EgPkOgeX+7PrSyav8obQTxuAjDK+BocummTFcfkzE+11RGHScOQPpIzDSeDWzdy2yU X-Gm-Message-State: AOJu0YzXzzflQl8ag7WxzP5RkUKkngU/ImQx3yqP1nMwxJvQyh1F+VpI HIziJK+pJgMBPRn1wg2IUmXCnKICMvYAzHzGdSobnsqyw2JX/giqiH454P0cLQ== X-Google-Smtp-Source: AGHT+IHSFBLxqKfwBYFhWQUcPLu79xM0tEg3agHZiy5LI1aOxWfQi37HgZXaOSegYnMxUKSZxpp62g== X-Received: by 2002:a05:6808:3a0c:b0:3c3:d731:ae51 with SMTP id gr12-20020a0568083a0c00b003c3d731ae51mr15293684oib.29.1711943703486; Sun, 31 Mar 2024 20:55:03 -0700 (PDT) Received: from PC-MID-R740.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id j26-20020a62b61a000000b006e73d1c0c0esm6860781pff.154.2024.03.31.20.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Mar 2024 20:55:02 -0700 (PDT) From: Pavan Chebbi To: michael.chan@broadcom.com Cc: davem@davemloft.net, edumazet@google.com, gospo@broadcom.com, kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, Sreekanth Reddy , Kalesh AP , Somnath Kotur , Pavan Chebbi Subject: [PATCH net-next 7/7] bnxt_en: Add warning message about disallowed speed change Date: Sun, 31 Mar 2024 20:57:30 -0700 Message-Id: <20240401035730.306790-8-pavan.chebbi@broadcom.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240401035730.306790-1-pavan.chebbi@broadcom.com> References: <20240401035730.306790-1-pavan.chebbi@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Sreekanth Reddy Some chips may not allow changing default speed when dual rate transceivers modules are used. Firmware on those chips will indicate the same to the driver. Add a warning message when speed change is not supported because a dual rate transceiver is detected by the NIC. Signed-off-by: Sreekanth Reddy Reviewed-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Michael Chan Signed-off-by: Pavan Chebbi --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 1494b550299a..e64c681e2be8 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -2525,6 +2525,11 @@ static bool bnxt_event_error_report(struct bnxt *bp, u32 data1, u32 data2) } return false; } + case ASYNC_EVENT_CMPL_ERROR_REPORT_BASE_EVENT_DATA1_ERROR_TYPE_DUAL_DATA_RATE_NOT_SUPPORTED: + netdev_warn(bp->dev, + "Speed change not supported with dual rate transceivers on this board\n" + ); + break; default: netdev_err(bp->dev, "FW reported unknown error type %u\n", err_type);