diff mbox series

[5/6] arm64: dts: qcom: sa8540p-ride: remove tx-sched-sp property

Message ID 20240405152800.638461-6-f.suligoi@asem.it (mailing list archive)
State Changes Requested
Headers show
Series Remove stmmac tx-sched-sp property from documentation and DT | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Flavio Suligoi April 5, 2024, 3:27 p.m. UTC
The property "tx-sched-sp" no longer exists, as it was removed from the
file:

drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

by the commit:

commit aed6864035b1 ("net: stmmac: platform: Delete a redundant condition
branch")

Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
---
 arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 2 --
 1 file changed, 2 deletions(-)

Comments

Krzysztof Kozlowski April 5, 2024, 3:51 p.m. UTC | #1
On 05/04/2024 17:27, Flavio Suligoi wrote:
> The property "tx-sched-sp" no longer exists, as it was removed from the
> file:
> 
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> 
> by the commit:
> 
> commit aed6864035b1 ("net: stmmac: platform: Delete a redundant condition
> branch")

Same problem with commit. BTW, your commit msg does not say what happens
if this property is removed. Instead it could be "Strict priority is by
default in Linux driver and tx-sched-sp was removed in commit sha ("foo
bar")".


With fixed in commit msg.

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
index 177b9dad6ff7..11663cf81e45 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
@@ -225,7 +225,6 @@  queue3 {
 
 	ethernet0_mtl_tx_setup: tx-queues-config {
 		snps,tx-queues-to-use = <1>;
-		snps,tx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;
@@ -302,7 +301,6 @@  queue3 {
 
 	ethernet1_mtl_tx_setup: tx-queues-config {
 		snps,tx-queues-to-use = <1>;
-		snps,tx-sched-sp;
 
 		queue0 {
 			snps,dcb-algorithm;