| Message ID | 20240408-rockchip-dwmac-rgmii-id-binding-v1-1-3886d1a8bd54@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 220d63f249ecfa71a9b89dd232383506b56d0073 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: net: rockchip-dwmac: use rgmii-id in example | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Mon, Apr 08, 2024 at 08:44:10AM +0200, Sascha Hauer wrote: > The dwmac supports specifying the RGMII clock delays, but it is > recommended to use rgmii-id and to specify the delays in the phy node > instead [1]. > > Change the example accordingly to no longer promote this undesired > setting. > > [1] https://lore.kernel.org/all/1a0de7b4-f0f7-4080-ae48-f5ffa9e76be3@lunn.ch/ > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello Sascha, On 2024-04-08 08:44, Sascha Hauer wrote: > The dwmac supports specifying the RGMII clock delays, but it is > recommended to use rgmii-id and to specify the delays in the phy node > instead [1]. > > Change the example accordingly to no longer promote this undesired > setting. > > [1] > https://lore.kernel.org/all/1a0de7b4-f0f7-4080-ae48-f5ffa9e76be3@lunn.ch/ > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> I'd suggest that the following link is also added to the patch description as a reference, because it contains rather useful information: https://lore.kernel.org/linux-rockchip/2973a2cb1f478031ae6d478c853c33ae@manjaro.org/ Otherwise, Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index 70bbc4220e2ac..6bbe96e352509 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -137,8 +137,6 @@ examples: > assigned-clock-parents = <&ext_gmac>; > > rockchip,grf = <&grf>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-id"; > clock_in_out = "input"; > - tx_delay = <0x30>; > - rx_delay = <0x10>; > }; > > --- > base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f > change-id: 20240408-rockchip-dwmac-rgmii-id-binding-6166af659845 > > Best regards,
Am Montag, 8. April 2024, 08:44:10 CEST schrieb Sascha Hauer: > The dwmac supports specifying the RGMII clock delays, but it is > recommended to use rgmii-id and to specify the delays in the phy node > instead [1]. > > Change the example accordingly to no longer promote this undesired > setting. > > [1] https://lore.kernel.org/all/1a0de7b4-f0f7-4080-ae48-f5ffa9e76be3@lunn.ch/ > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index 70bbc4220e2ac..6bbe96e352509 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -137,8 +137,6 @@ examples: > assigned-clock-parents = <&ext_gmac>; > > rockchip,grf = <&grf>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-id"; > clock_in_out = "input"; > - tx_delay = <0x30>; > - rx_delay = <0x10>; > }; > > --- > base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f > change-id: 20240408-rockchip-dwmac-rgmii-id-binding-6166af659845 > > Best regards, >
On Mon, Apr 08, 2024 at 08:44:10AM +0200, Sascha Hauer wrote: > The dwmac supports specifying the RGMII clock delays, but it is > recommended to use rgmii-id and to specify the delays in the phy node > instead [1]. > > Change the example accordingly to no longer promote this undesired > setting. > > [1] https://lore.kernel.org/all/1a0de7b4-f0f7-4080-ae48-f5ffa9e76be3@lunn.ch/ > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Mon, 08 Apr 2024 08:44:10 +0200 you wrote: > The dwmac supports specifying the RGMII clock delays, but it is > recommended to use rgmii-id and to specify the delays in the phy node > instead [1]. > > Change the example accordingly to no longer promote this undesired > setting. > > [...] Here is the summary with links: - dt-bindings: net: rockchip-dwmac: use rgmii-id in example https://git.kernel.org/netdev/net-next/c/220d63f249ec You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index 70bbc4220e2ac..6bbe96e352509 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -137,8 +137,6 @@ examples: assigned-clock-parents = <&ext_gmac>; rockchip,grf = <&grf>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; clock_in_out = "input"; - tx_delay = <0x30>; - rx_delay = <0x10>; };
The dwmac supports specifying the RGMII clock delays, but it is recommended to use rgmii-id and to specify the delays in the phy node instead [1]. Change the example accordingly to no longer promote this undesired setting. [1] https://lore.kernel.org/all/1a0de7b4-f0f7-4080-ae48-f5ffa9e76be3@lunn.ch/ Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f change-id: 20240408-rockchip-dwmac-rgmii-id-binding-6166af659845 Best regards,