From patchwork Tue Apr 9 21:54:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 13623279 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C51D9158D70 for ; Tue, 9 Apr 2024 21:54:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699696; cv=none; b=a3joH138IIFGw7DRZc2VTuS/uUG6zHph/IW3vzkts9vpbqeFE5WemVz7+OpRdA5/Z1liKc7ujsLcxo8rIK562oKdfdP1zwFJAP21kaogfwyR6CzfFWrIioERCQD5iyScpjYGc1dj8ETnBrxbofQGqqnfBOZl5x1ad5pn751kvjA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699696; c=relaxed/simple; bh=StFW7/nRK2KNMwYnAHda7tVJzsil5oUoUnzi+R/NdGc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=izzo2CdtMV7HjB6BpCr3YGLcjrdJJrBxTQxCFXXCq/dKOP4C4+AYXMyQk+D30Lq1B+0ufaZjcX4oxjzBgRPb12xn/ieizOqy2kRwVF55YFqMCkMvGtg3TUdkzTP+nDXJ9pc8EmLzJDFZdaVZpr4RTZVtITSbHLu7daIcf47pq0A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=X5IrU6PL; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="X5IrU6PL" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-5d3907ff128so5116397a12.3 for ; Tue, 09 Apr 2024 14:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1712699694; x=1713304494; darn=vger.kernel.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=E9HOG+p18/YwVjGzDQQFCoXS65i4FGfH9omv2K3d+N8=; b=X5IrU6PLYDfuVaYOHDCi3sUyLiPAGfJaEuHUHJome3Yh41LbJ/e2mk6lWza79QfgfM 3WZbQqkZelxHqUkRtueL91g4hZP7k+kdvHknXF9kpAKAk6yBz9JFsopndAAFWfcdTi4u cq/Tb4IESFv+8wCyXR+8wLJfpuda2DX0vNZ4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712699694; x=1713304494; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E9HOG+p18/YwVjGzDQQFCoXS65i4FGfH9omv2K3d+N8=; b=RjwpI6ISETnYV1YVtnfT7W8+k9yie/pjeF2RKfyusxnqeAiGIEQCCn1IJRwIoENdVh lpKzRugxfToroHqm5KdPWYLIdsviUH4oV6FhAL4E8WAPst7jV37Xed+oqqSCc+zEehhO URc8mVcgfVvg2QREvGYgqgVrEL27/PE2/SpW7Eqfug5pf/vO64+BfI7DLiGTP6l5DOJ4 yW/kWzB8tBIHwY9sVMJ72mt/pO9vqEkNGPyD098jJSighsIpV2k8QseKmNVgnahEUz65 Xc/o8oDz92NgdXmmZEV866VNzlEEkAuWLdsAGZryQfmPHdYVK/7TMSmaxBxuqI76Oxto R0Pw== X-Gm-Message-State: AOJu0YxJ7SInMxHJSB8XQkmPU+eN5kqrWUnEdHxSMNq6/EVGZLlUgcKS qJ7lDBo/0aPgonEh0DVXodPZz8RlCC3Z5ov2LkCOUlEFjGTw65VV/84XPdWaYg== X-Google-Smtp-Source: AGHT+IFiIhW/S532G8p8d9b6XC3JOCGSDZoLQDzghxI4njb5JCxgVE2siuTMd60UOw6XyF8QyCZrhA== X-Received: by 2002:a17:902:da86:b0:1e4:55d8:e5f1 with SMTP id j6-20020a170902da8600b001e455d8e5f1mr1267749plx.5.1712699693645; Tue, 09 Apr 2024 14:54:53 -0700 (PDT) Received: from lvnvda5233.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id cp12-20020a170902e78c00b001e3e081dea1sm6983687plb.0.2024.04.09.14.54.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2024 14:54:52 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com, Kalesh AP , Vikas Gupta , Somnath Kotur Subject: [PATCH net-next 2/7] bnxt_en: Remove a redundant NULL check in bnxt_register_dev() Date: Tue, 9 Apr 2024 14:54:26 -0700 Message-Id: <20240409215431.41424-3-michael.chan@broadcom.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20240409215431.41424-1-michael.chan@broadcom.com> References: <20240409215431.41424-1-michael.chan@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Kalesh AP The memory for "edev->ulp_tbl" is allocated inside the bnxt_rdma_aux_device_init() function. If it fails, the driver will not create the auxiliary device for RoCE. Hence the NULL check inside bnxt_register_dev() is unnecessary. Reviewed-by: Vikas Gupta Reviewed-by: Somnath Kotur Signed-off-by: Kalesh AP Signed-off-by: Michael Chan Reviewed-by: Jacob Keller --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c index 86dcd2c76587..fd890819d4bc 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c @@ -64,9 +64,6 @@ int bnxt_register_dev(struct bnxt_en_dev *edev, return -ENOMEM; ulp = edev->ulp_tbl; - if (!ulp) - return -ENOMEM; - ulp->handle = handle; rcu_assign_pointer(ulp->ulp_ops, ulp_ops);