| Message ID | 20240411012815.174400-5-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: net: exercise page pool reporting via netlink | expand |
Jakub Kicinski <kuba@kernel.org> writes: > Instead of a summary line print the full exception. > This makes debugging Python tests much easier. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Petr Machata <petrm@nvidia.com> > @@ -85,7 +86,8 @@ KSFT_RESULT = None > totals['xfail'] += 1 > continue > except Exception as e: > - for line in str(e).split('\n'): > + tb = traceback.format_exc() > + for line in tb.strip().split('\n'): (The strip is necessary to get rid of trailing newlines.) > ksft_pr("Exception|", line) > ktap_result(False, cnt, case) > totals['fail'] += 1
diff --git a/tools/testing/selftests/net/lib/py/ksft.py b/tools/testing/selftests/net/lib/py/ksft.py index 5838aadd95a7..6e1f4685669c 100644 --- a/tools/testing/selftests/net/lib/py/ksft.py +++ b/tools/testing/selftests/net/lib/py/ksft.py @@ -2,6 +2,7 @@ import builtins import inspect +import traceback from .consts import KSFT_MAIN_NAME KSFT_RESULT = None @@ -85,7 +86,8 @@ KSFT_RESULT = None totals['xfail'] += 1 continue except Exception as e: - for line in str(e).split('\n'): + tb = traceback.format_exc() + for line in tb.strip().split('\n'): ksft_pr("Exception|", line) ktap_result(False, cnt, case) totals['fail'] += 1
Instead of a summary line print the full exception. This makes debugging Python tests much easier. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- tools/testing/selftests/net/lib/py/ksft.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)