| Message ID | 20240412173332.186685-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v1,1/1] can: mcp251x: Fix up includes | expand |
On Sat. 13 Apr. 2024 at 02:33, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > This driver is including the legacy GPIO header <linux/gpio.h> > but the only thing it is using from that header is the wrong > define for GPIOF_DIR_OUT. > > Fix it up by using GPIO_LINE_DIRECTION_* macros respectively. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thank you for the patch. Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
On Fri, Apr 12, 2024 at 08:33:32PM +0300, Andy Shevchenko wrote: > This driver is including the legacy GPIO header <linux/gpio.h> > but the only thing it is using from that header is the wrong > define for GPIOF_DIR_OUT. > > Fix it up by using GPIO_LINE_DIRECTION_* macros respectively. Marc, any comments on this?
diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c index 79c4bab5f724..643974b3f329 100644 --- a/drivers/net/can/spi/mcp251x.c +++ b/drivers/net/can/spi/mcp251x.c @@ -28,7 +28,6 @@ #include <linux/device.h> #include <linux/ethtool.h> #include <linux/freezer.h> -#include <linux/gpio.h> #include <linux/gpio/driver.h> #include <linux/interrupt.h> #include <linux/io.h> @@ -482,9 +481,9 @@ static int mcp251x_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) { if (mcp251x_gpio_is_input(offset)) - return GPIOF_DIR_IN; + return GPIO_LINE_DIRECTION_IN; - return GPIOF_DIR_OUT; + return GPIO_LINE_DIRECTION_OUT; } static int mcp251x_gpio_get(struct gpio_chip *chip, unsigned int offset)
This driver is including the legacy GPIO header <linux/gpio.h> but the only thing it is using from that header is the wrong define for GPIOF_DIR_OUT. Fix it up by using GPIO_LINE_DIRECTION_* macros respectively. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/net/can/spi/mcp251x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)