diff mbox series

[net-next,v8,02/17] of: property: Add fw_devlink support for pse parent

Message ID 20240414-feature_poe-v8-2-e4bf1e860da5@bootlin.com (mailing list archive)
State Accepted
Commit 93c0d8c0ac309cc927c0b5e9a52af4c954d66da5
Delegated to: Netdev Maintainers
Headers show
Series [net-next,v8,01/17] MAINTAINERS: net: Add Oleksij to pse-pd maintainers | expand

Checks

Context Check Description
netdev/series_format fail Series does not have a cover letter; Series longer than 15 patches (and no cover letter)
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; GEN HAS DIFF 2 files changed, 96 insertions(+), 39 deletions(-);
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 928 this patch: 928
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers fail 2 maintainers not CCed: robh@kernel.org saravanak@google.com
netdev/build_clang success Errors and warnings before: 938 this patch: 938
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 939 this patch: 939
netdev/checkpatch warning CHECK: From:/Signed-off-by: email comments mismatch: 'From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>' != 'Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>'
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 6 this patch: 6
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-04-15--15-00 (tests: 961)

Commit Message

Kory Maincent April 14, 2024, 2:21 p.m. UTC 
From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

This allows fw_devlink to create device links between consumers of
a PSE and the supplier of the PSE.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Changes in v3:
- New patch
---
 drivers/of/property.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Saravana Kannan April 24, 2024, 5:48 a.m. UTC | #1 
On Sun, Apr 14, 2024 at 7:21 AM Kory Maincent <kory.maincent@bootlin.com> wrote:
>
> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
>
> This allows fw_devlink to create device links between consumers of
> a PSE and the supplier of the PSE.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

As the fw_devlink, I'd have preferred to be CC'ed on this patch before
it got pulled in. Especially since Andrew thought this might get
fw_devlink in a knot.

-Saravana
> ---
>
> Changes in v3:
> - New patch
> ---
>  drivers/of/property.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index a6358ee99b74..cc064151853e 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1252,6 +1252,7 @@ DEFINE_SIMPLE_PROP(backlight, "backlight", NULL)
>  DEFINE_SIMPLE_PROP(panel, "panel", NULL)
>  DEFINE_SIMPLE_PROP(msi_parent, "msi-parent", "#msi-cells")
>  DEFINE_SIMPLE_PROP(post_init_providers, "post-init-providers", NULL)
> +DEFINE_SIMPLE_PROP(pses, "pses", "#pse-cells")
>  DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
>  DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
>
> @@ -1357,6 +1358,7 @@ static const struct supplier_bindings of_supplier_bindings[] = {
>         { .parse_prop = parse_backlight, },
>         { .parse_prop = parse_panel, },
>         { .parse_prop = parse_msi_parent, },
> +       { .parse_prop = parse_pses, },
>         { .parse_prop = parse_gpio_compat, },
>         { .parse_prop = parse_interrupts, },
>         { .parse_prop = parse_regulators, },
>
> --
> 2.34.1
>
>
Kory Maincent April 24, 2024, 7:59 a.m. UTC | #2 
On Tue, 23 Apr 2024 22:48:12 -0700
Saravana Kannan <saravanak@google.com> wrote:

> On Sun, Apr 14, 2024 at 7:21 AM Kory Maincent <kory.maincent@bootlin.com>
> wrote:
> >
> > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> >
> > This allows fw_devlink to create device links between consumers of
> > a PSE and the supplier of the PSE.
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>  
> 
> As the fw_devlink, I'd have preferred to be CC'ed on this patch before
> it got pulled in. Especially since Andrew thought this might get
> fw_devlink in a knot.

Oh indeed you are not on the CC list!
I might have forgotten to run the b4 command to update the CC list after having
added this patch. Sorry for that.

Regards,
diff mbox series

Patch

diff --git a/drivers/of/property.c b/drivers/of/property.c
index a6358ee99b74..cc064151853e 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1252,6 +1252,7 @@  DEFINE_SIMPLE_PROP(backlight, "backlight", NULL)
 DEFINE_SIMPLE_PROP(panel, "panel", NULL)
 DEFINE_SIMPLE_PROP(msi_parent, "msi-parent", "#msi-cells")
 DEFINE_SIMPLE_PROP(post_init_providers, "post-init-providers", NULL)
+DEFINE_SIMPLE_PROP(pses, "pses", "#pse-cells")
 DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
 DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
 
@@ -1357,6 +1358,7 @@  static const struct supplier_bindings of_supplier_bindings[] = {
 	{ .parse_prop = parse_backlight, },
 	{ .parse_prop = parse_panel, },
 	{ .parse_prop = parse_msi_parent, },
+	{ .parse_prop = parse_pses, },
 	{ .parse_prop = parse_gpio_compat, },
 	{ .parse_prop = parse_interrupts, },
 	{ .parse_prop = parse_regulators, },