| Message ID | 20240415100713.483399-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c2b640529ec7595b4f82f1630da1ac9697a0c927 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next] net/handshake: remove redundant assignment to variable ret | expand |
On Mon, Apr 15, 2024 at 6:08 PM Colin Ian King <colin.i.king@gmail.com> wrote: > > The variable is being assigned an value and then is being re-assigned > a new value in the next statement. The assignment is redundant and can > be removed. > > Cleans up clang scan build warning: > net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never > read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
On Mon, Apr 15, 2024 at 11:07:13AM +0100, Colin Ian King wrote: > The variable is being assigned an value and then is being re-assigned > a new value in the next statement. The assignment is redundant and can > be removed. > > Cleans up clang scan build warning: > net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never > read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > net/handshake/tlshd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/handshake/tlshd.c b/net/handshake/tlshd.c > index d697f68c598c..d6f52839827e 100644 > --- a/net/handshake/tlshd.c > +++ b/net/handshake/tlshd.c > @@ -213,7 +213,6 @@ static int tls_handshake_accept(struct handshake_req *req, > if (!hdr) > goto out_cancel; > > - ret = -EMSGSIZE; > ret = nla_put_s32(msg, HANDSHAKE_A_ACCEPT_SOCKFD, fd); > if (ret < 0) > goto out_cancel; > -- > 2.39.2 > > Acked-by: Chuck Lever <chuck.lever@oracle.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 15 Apr 2024 11:07:13 +0100 you wrote: > The variable is being assigned an value and then is being re-assigned > a new value in the next statement. The assignment is redundant and can > be removed. > > Cleans up clang scan build warning: > net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never > read [deadcode.DeadStores] > > [...] Here is the summary with links: - [next] net/handshake: remove redundant assignment to variable ret https://git.kernel.org/netdev/net-next/c/c2b640529ec7 You are awesome, thank you!
diff --git a/net/handshake/tlshd.c b/net/handshake/tlshd.c index d697f68c598c..d6f52839827e 100644 --- a/net/handshake/tlshd.c +++ b/net/handshake/tlshd.c @@ -213,7 +213,6 @@ static int tls_handshake_accept(struct handshake_req *req, if (!hdr) goto out_cancel; - ret = -EMSGSIZE; ret = nla_put_s32(msg, HANDSHAKE_A_ACCEPT_SOCKFD, fd); if (ret < 0) goto out_cancel;
The variable is being assigned an value and then is being re-assigned a new value in the next statement. The assignment is redundant and can be removed. Cleans up clang scan build warning: net/handshake/tlshd.c:216:2: warning: Value stored to 'ret' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- net/handshake/tlshd.c | 1 - 1 file changed, 1 deletion(-)