From patchwork Mon Apr 22 01:54:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xuan Zhuo X-Patchwork-Id: 13637588 X-Patchwork-Delegate: kuba@kernel.org Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A17C7205E33 for ; Mon, 22 Apr 2024 01:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.110 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713750863; cv=none; b=AmpZrBp90dDTEaGIvtMVmjBJQIjjclgaMjaLgxmhwFkQLTMPvbLJ8RlkIz5l1CBx9aTGyrC4Urrc048fWJ7BbTcALtZpa1le3qIYqsL7qGYGb4Cm+fW6fPhjQ3zXzFMrNAn05ZEUEupn4Nl/j5SKWvzzBdcdcGPYa5xvb+uDoIY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713750863; c=relaxed/simple; bh=RI9oBferiUfhUZJIfb5WszLvNGIFPD09N8cV69d/2jA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LajpH675+zWYfwD9Br9QX4CDbkqkV5lN2Gg9lVO17aN9VfSYX8MBxPd/yYNjy4ZqpYn0r5YT8Ve6iZq7tb2rMfs3D/0SAYkq0kreewqzh0JLFeMcCf9XtjAYFRr8MR+E2m8Cc/4vmX4ffACdab6Ln28BN9dJWA8WqBxNyykqbZA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=RXcdOw8p; arc=none smtp.client-ip=115.124.30.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="RXcdOw8p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1713750854; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=5EOVd0kTxPUl+7GWsixYT0vlMbIjWLtjuePm8Pe+IaE=; b=RXcdOw8p4Ct4K+dz0pCLAhlg5EtIFddKKM1N6o6M+FeIWcUQZSITko283Pv+21xI/odg9xiXVNTmpLZLgQ4ZEf38cXCcaQMadXDIVffuu4CD7JIBnWlwfTMHHGUFX9I2XGm3wewmfaFS6QD4TFo1E39X8l/8Jz2Xbvc/ipAZ6gs= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0W4yCK5L_1713750853; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0W4yCK5L_1713750853) by smtp.aliyun-inc.com; Mon, 22 Apr 2024 09:54:13 +0800 From: Xuan Zhuo To: virtualization@lists.linux.dev Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Subject: [PATCH vhost v1 7/7] virtio_net: remove the misleading comment Date: Mon, 22 Apr 2024 09:54:03 +0800 Message-Id: <20240422015403.72526-8-xuanzhuo@linux.alibaba.com> X-Mailer: git-send-email 2.32.0.3.g01195cf9f In-Reply-To: <20240422015403.72526-1-xuanzhuo@linux.alibaba.com> References: <20240422015403.72526-1-xuanzhuo@linux.alibaba.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Git-Hash: 2c089e81de7e X-Patchwork-Delegate: kuba@kernel.org We call the build_skb() actually without copying data. The comment is misleading. So remove it. Signed-off-by: Xuan Zhuo --- drivers/net/virtio_net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index eff8f16a9fe0..a8dac48a1be7 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -690,7 +690,6 @@ static struct sk_buff *page_to_skb(struct virtnet_info *vi, shinfo_size = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); - /* copy small packet so we can reuse these pages */ if (!NET_IP_ALIGN && len > GOOD_COPY_LEN && tailroom >= shinfo_size) { skb = virtnet_build_skb(buf, truesize, p - buf, len); if (unlikely(!skb))