| Message ID | 20240424011454.1554088-1-make_ruc2021@163.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: usb: ax88179_178a: Add check for usbnet_get_endpoints() | expand |
See inline, > To avoid the failure of usbnet_get_endpoints(), we should check the return > value of the usbnet_get_endpoints(). > > Signed-off-by: Ma Ke <make_ruc2021@163.com> > --- > drivers/net/usb/ax88179_178a.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/usb/ax88179_178a.c > b/drivers/net/usb/ax88179_178a.c index 752f821a1990..cf8d19584725 > 100644 > --- a/drivers/net/usb/ax88179_178a.c > +++ b/drivers/net/usb/ax88179_178a.c > @@ -1288,7 +1288,9 @@ static int ax88179_bind(struct usbnet *dev, struct > usb_interface *intf) { > struct ax88179_data *ax179_data; > > - usbnet_get_endpoints(dev, intf); > + ret = usbnet_get_endpoints(dev, intf); > + if (ret < 0) > + return ret; Don't we need to declare "ret" variable. Did you compiled this patch before submitting. Thanks, Hariprasad k > > ax179_data = kzalloc(sizeof(*ax179_data), GFP_KERNEL); > if (!ax179_data) > -- > 2.37.2 >
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 752f821a1990..cf8d19584725 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1288,7 +1288,9 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) { struct ax88179_data *ax179_data; - usbnet_get_endpoints(dev, intf); + ret = usbnet_get_endpoints(dev, intf); + if (ret < 0) + return ret; ax179_data = kzalloc(sizeof(*ax179_data), GFP_KERNEL); if (!ax179_data)
To avoid the failure of usbnet_get_endpoints(), we should check the return value of the usbnet_get_endpoints(). Signed-off-by: Ma Ke <make_ruc2021@163.com> --- drivers/net/usb/ax88179_178a.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)