From patchwork Wed Apr 24 08:16:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xuan Zhuo X-Patchwork-Id: 13641518 X-Patchwork-Delegate: kuba@kernel.org Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E037158871 for ; Wed, 24 Apr 2024 08:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.111 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713946614; cv=none; b=HsyWJZ1/3z8htHVNkwTyMNGwZHuEIHmQ+Qwj62l6sYeflBvt6lDRzQsIr11RN+pnguFJnLY0gzl1l8pq39TREHowC9vxVYJTwilND+3MKMcZ38eUeDdYBWoMFodAISHFxlBHRRKXhNiy9dH01//l02LPMVbXrGi8jXdesU0Su4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713946614; c=relaxed/simple; bh=z8jerKRDUxs2eTUDwkeWnIYa4pVTDPiVI6jep0yvqhs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lZC5diIuzhM+d3q67ePP5LzsMmw7ippdpCRpXtVv0C6yrUytNl+B83/w7wPDwIGS2sncGnflNztj8hHjzeKosgqZMyysD05ki+/0pNB+H+yc3UcDulTxqXGAa/IqRmkBJJTe3wgCM2QN16yXlVvkkvA9nwNWK0TDjFEoKmDCSmQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=b5C05YDu; arc=none smtp.client-ip=115.124.30.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="b5C05YDu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1713946604; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=tWRTicwf67dXxyQhQVOHVww5BQsSp7CJZbGq1DNkb48=; b=b5C05YDu/V3N1qK8Chz0Re6foNqlDaTy8XIS58ZGnfV7OF2Y2FQQcMVnsxcCI8/XirJVYHRmLg2xQcucr035wVUWEhyPlZ47a10/fG2m3ZsfDJOaw0r0Lvf4XpsdrV3Hd1ehMJrTzKZ6OFRHqXfG2HmHWeSgOyvCXzvkxPwoA80= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033068173054;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0W5BhZ5S_1713946602; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0W5BhZ5S_1713946602) by smtp.aliyun-inc.com; Wed, 24 Apr 2024 16:16:43 +0800 From: Xuan Zhuo To: virtualization@lists.linux.dev Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Subject: [PATCH vhost v3 4/4] virtio_net: remove the misleading comment Date: Wed, 24 Apr 2024 16:16:36 +0800 Message-Id: <20240424081636.124029-5-xuanzhuo@linux.alibaba.com> X-Mailer: git-send-email 2.32.0.3.g01195cf9f In-Reply-To: <20240424081636.124029-1-xuanzhuo@linux.alibaba.com> References: <20240424081636.124029-1-xuanzhuo@linux.alibaba.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Git-Hash: 55c7001bc45b X-Patchwork-Delegate: kuba@kernel.org We call the build_skb() actually without copying data. The comment is misleading. So remove it. Signed-off-by: Xuan Zhuo Acked-by: Jason Wang --- drivers/net/virtio_net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index a4b924ba18d3..3e8694837a29 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -600,7 +600,6 @@ static struct sk_buff *page_to_skb(struct virtnet_info *vi, shinfo_size = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); - /* copy small packet so we can reuse these pages */ if (!NET_IP_ALIGN && len > GOOD_COPY_LEN && tailroom >= shinfo_size) { skb = virtnet_build_skb(buf, truesize, p - buf, len); if (unlikely(!skb))