| Message ID | 20240424221444.4194069-2-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: drv-net: round some sharp edges | expand |
On Wed, 24 Apr 2024 15:14:41 -0700 Jakub Kicinski wrote: > This is not yet needed, because we don't terminate remote background > commands. But once we do, if we run ssh without -t the ssh session > may close and the program may carry on happily running. > > I have hit this problem experimenting with mausezahn, let's fix > it already to avoid someone else wasting time debugging it. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > tools/testing/selftests/drivers/net/lib/py/remote_ssh.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py b/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py > index 924addde19a3..294a4ed8284e 100644 > --- a/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py > +++ b/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py > @@ -20,7 +20,7 @@ from lib.py import cmd > self._tmpdir = None > > def cmd(self, comm): > - return subprocess.Popen(["ssh", "-q", self.name, comm], > + return subprocess.Popen(["ssh", "-t", "-q", self.name, comm], > stdout=subprocess.PIPE, stderr=subprocess.PIPE) This seems to mess up the local terminal. I guess we'll cross that bridge when we get there... I'll drop this patch when applying.
diff --git a/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py b/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py index 924addde19a3..294a4ed8284e 100644 --- a/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py +++ b/tools/testing/selftests/drivers/net/lib/py/remote_ssh.py @@ -20,7 +20,7 @@ from lib.py import cmd self._tmpdir = None def cmd(self, comm): - return subprocess.Popen(["ssh", "-q", self.name, comm], + return subprocess.Popen(["ssh", "-t", "-q", self.name, comm], stdout=subprocess.PIPE, stderr=subprocess.PIPE) def _mktmp(self):
This is not yet needed, because we don't terminate remote background commands. But once we do, if we run ssh without -t the ssh session may close and the program may carry on happily running. I have hit this problem experimenting with mausezahn, let's fix it already to avoid someone else wasting time debugging it. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- tools/testing/selftests/drivers/net/lib/py/remote_ssh.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)