From patchwork Thu Apr 25 13:59:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Tissoires X-Patchwork-Id: 13643399 X-Patchwork-Delegate: bpf@iogearbox.net Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AABD6149E1A; Thu, 25 Apr 2024 13:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714053567; cv=none; b=ZNusgrClbFZFP2/TEsY20+y0DLzyiCBVjBam142hGF84gAtnsHLQfY4MxzU4M+Wxg4m33nW8z2pX+gajy5luPZvGSU/yGZQvj2GGGDORWLkQbl9PEUlEl6bEJ5jJ4/E9Y7jSTGWsgpdXh+4hjjdoAYEsp1blZ1KpHuBjpQjtFqk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714053567; c=relaxed/simple; bh=0UjWtmDw4NdWdiV9RiGFH2oVaGYWk2wAWC/NqY/by9Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ei1rgL8me9c+C3ekFzDbLUIqIl/c3XVvSfjsz09DCHQdaTFBKwRaKuKjasJkJa5i045TkwKmPdgSvis6VUI2b551X6vekRP1y/j7PvFSsu0qBjeVENzYjavJxElcCF3RzZUVDqsCC+LbvPjD4KGJ30zzpaDNsMLr88UrqCvW/vs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gjQcqWbv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gjQcqWbv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB899C32783; Thu, 25 Apr 2024 13:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714053566; bh=0UjWtmDw4NdWdiV9RiGFH2oVaGYWk2wAWC/NqY/by9Y=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=gjQcqWbveWT4Z3rfSXEl8UidlmtW2NjT9zckTQTkeo5WUxvUK14hRzMfntdGZJZw6 3chcFyQXhhSkQ0KP6pnigxqxM2jVH9GVgkc3vg/u4ynDVh56TkgMBDUXh/0KIzzOgY VvfVH+sAHiReO19p+7Qkx84eOekFWVB7KDYQrnDllSVI6ip/W1aIIw80KyQmQrtxZp oBCFGFBxqP6pcZL21v3fbVXLW5eC8LMjlWA79+d9xwQ8aTVmzPgEMnJbloE+uH+CI3 YrWX6iCoBW+CG25wfuqjgs36c8VihCyav2vn9ZjolqoEdKFgdIV3oSZ/7WKopJVrTP oP/xkv85jvq7w== From: Benjamin Tissoires Date: Thu, 25 Apr 2024 15:59:12 +0200 Subject: [PATCH 1/3] bpf: do not walk twice the map on free Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240425-bpf-next-v1-1-1d8330e6c643@kernel.org> References: <20240425-bpf-next-v1-0-1d8330e6c643@kernel.org> In-Reply-To: <20240425-bpf-next-v1-0-1d8330e6c643@kernel.org> To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Benjamin Tissoires X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714053558; l=1632; i=bentiss@kernel.org; s=20230215; h=from:subject:message-id; bh=0UjWtmDw4NdWdiV9RiGFH2oVaGYWk2wAWC/NqY/by9Y=; b=RKtnAsLvD2iqjvzpo5k2I1Q4VyNf7Rj1fx5HEQ/MKI+iKzaLwwaZr/XnRQswXFymVJeBFXfYW gqBO+/jQGrtA7khINJp9kK4fFri609NjGRLuTokCwimqhrKmAoER7J8 X-Developer-Key: i=bentiss@kernel.org; a=ed25519; pk=7D1DyAVh6ajCkuUTudt/chMuXWIJHlv2qCsRkIizvFw= X-Patchwork-Delegate: bpf@iogearbox.net If someone stores both a timer and a workqueue in a map, on free we would walk it twice. Add a check in array_map_free_timers_wq and free the timers and workqueues if they are present. Fixes: 246331e3f1ea ("bpf: allow struct bpf_wq to be embedded in arraymaps and hashmaps") Signed-off-by: Benjamin Tissoires --- kernel/bpf/arraymap.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c index 580d07b15471..feabc0193852 100644 --- a/kernel/bpf/arraymap.c +++ b/kernel/bpf/arraymap.c @@ -436,13 +436,14 @@ static void array_map_free_timers_wq(struct bpf_map *map) /* We don't reset or free fields other than timer and workqueue * on uref dropping to zero. */ - if (btf_record_has_field(map->record, BPF_TIMER)) - for (i = 0; i < array->map.max_entries; i++) - bpf_obj_free_timer(map->record, array_map_elem_ptr(array, i)); - - if (btf_record_has_field(map->record, BPF_WORKQUEUE)) - for (i = 0; i < array->map.max_entries; i++) - bpf_obj_free_workqueue(map->record, array_map_elem_ptr(array, i)); + if (btf_record_has_field(map->record, BPF_TIMER | BPF_WORKQUEUE)) { + for (i = 0; i < array->map.max_entries; i++) { + if (btf_record_has_field(map->record, BPF_TIMER)) + bpf_obj_free_timer(map->record, array_map_elem_ptr(array, i)); + if (btf_record_has_field(map->record, BPF_WORKQUEUE)) + bpf_obj_free_workqueue(map->record, array_map_elem_ptr(array, i)); + } + } } /* Called when map->refcnt goes to zero, either from workqueue or from syscall */