| Message ID | 20240426232400.624864-2-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: net: page_poll allocation error injection | expand |
On 27/04/2024 01.23, Jakub Kicinski wrote: > Because of caching / recycling using the general page allocation > failures to induce errors in page pool allocation is very hard. > Add direct error injection support to page_pool_alloc_pages(). > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Sounds good to me :-) Acked-by: Jesper Dangaard Brouer <hawk@kernel.org> > --- > CC: hawk@kernel.org > CC: ilias.apalodimas@linaro.org > --- > net/core/page_pool.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 273c24429bce..8bcc7014a61a 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -5,6 +5,7 @@ > * Copyright (C) 2016 Red Hat, Inc. > */ > > +#include <linux/error-injection.h> > #include <linux/types.h> > #include <linux/kernel.h> > #include <linux/slab.h> > @@ -550,6 +551,7 @@ struct page *page_pool_alloc_pages(struct page_pool *pool, gfp_t gfp) > return page; > } > EXPORT_SYMBOL(page_pool_alloc_pages); > +ALLOW_ERROR_INJECTION(page_pool_alloc_pages, NULL); > > /* Calculate distance between two u32 values, valid if distance is below 2^(31) > * https://en.wikipedia.org/wiki/Serial_number_arithmetic#General_Solution
diff --git a/net/core/page_pool.c b/net/core/page_pool.c index 273c24429bce..8bcc7014a61a 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -5,6 +5,7 @@ * Copyright (C) 2016 Red Hat, Inc. */ +#include <linux/error-injection.h> #include <linux/types.h> #include <linux/kernel.h> #include <linux/slab.h> @@ -550,6 +551,7 @@ struct page *page_pool_alloc_pages(struct page_pool *pool, gfp_t gfp) return page; } EXPORT_SYMBOL(page_pool_alloc_pages); +ALLOW_ERROR_INJECTION(page_pool_alloc_pages, NULL); /* Calculate distance between two u32 values, valid if distance is below 2^(31) * https://en.wikipedia.org/wiki/Serial_number_arithmetic#General_Solution
Because of caching / recycling using the general page allocation failures to induce errors in page pool allocation is very hard. Add direct error injection support to page_pool_alloc_pages(). Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: hawk@kernel.org CC: ilias.apalodimas@linaro.org --- net/core/page_pool.c | 2 ++ 1 file changed, 2 insertions(+)