Message ID | 20240429131657.19423-1-daniel@iogearbox.net (mailing list archive) |
---|---|
State | Accepted |
Commit | 89de2db19317fb89a6e9163f33c3a7b23ee75a18 |
Headers | show |
Series | pull-request: bpf-next 2024-04-29 | expand |
Context | Check | Description |
---|---|---|
netdev/tree_selection | success | Pull request for net-next, async |
netdev/build_32bit | fail | Errors and warnings before: 7463 this patch: 7475 |
netdev/build_tools | success | Errors and warnings before: 1 this patch: 1 |
netdev/build_clang | success | Errors and warnings before: 1210 this patch: 1210 |
netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
netdev/verify_fixes | success | Fixes tag looks correct |
netdev/build_allmodconfig_warn | fail | Errors and warnings before: 7844 this patch: 7856 |
netdev/build_clang_rust | success | No Rust files in patch. Skipping build |
On Mon, 29 Apr 2024 15:16:57 +0200 Daniel Borkmann wrote:
> tools: Add ethtool.h header to tooling infra
Could you follow up to remove this header?
Having to keep multiple headers in sync is annoying, and using
'make headers' or including in-tree headers directly is not rocket
science.
Hello: This pull request was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 29 Apr 2024 15:16:57 +0200 you wrote: > Hi David, hi Jakub, hi Paolo, hi Eric, > > The following pull-request contains BPF updates for your *net-next* tree. > > We've added 147 non-merge commits during the last 32 day(s) which contain > a total of 158 files changed, 9400 insertions(+), 2213 deletions(-). > > [...] Here is the summary with links: - pull-request: bpf-next 2024-04-29 https://git.kernel.org/netdev/net-next/c/89de2db19317 You are awesome, thank you!
On 4/29/24 10:22 PM, Jakub Kicinski wrote: > On Mon, 29 Apr 2024 15:16:57 +0200 Daniel Borkmann wrote: >> tools: Add ethtool.h header to tooling infra > > Could you follow up to remove this header? > Having to keep multiple headers in sync is annoying, and using > 'make headers' or including in-tree headers directly is not rocket > science. [ Adding Tushar/Magnus, ptal. ]
> -----Original Message----- > From: Daniel Borkmann <daniel@iogearbox.net> > Sent: Tuesday, April 30, 2024 2:44 AM > To: Jakub Kicinski <kuba@kernel.org> > Cc: davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; > ast@kernel.org; andrii@kernel.org; martin.lau@linux.dev; > netdev@vger.kernel.org; bpf@vger.kernel.org; Vyavahare, Tushar > <tushar.vyavahare@intel.com>; Karlsson, Magnus > <magnus.karlsson@intel.com> > Subject: Re: pull-request: bpf-next 2024-04-29 > > On 4/29/24 10:22 PM, Jakub Kicinski wrote: > > On Mon, 29 Apr 2024 15:16:57 +0200 Daniel Borkmann wrote: > >> tools: Add ethtool.h header to tooling infra > > > > Could you follow up to remove this header? > > Having to keep multiple headers in sync is annoying, and using 'make > > headers' or including in-tree headers directly is not rocket science. > > [ Adding Tushar/Magnus, ptal. ] Sure , we are looking into it.
On Mon, 29 Apr 2024 at 22:22, Jakub Kicinski <kuba@kernel.org> wrote: > > On Mon, 29 Apr 2024 15:16:57 +0200 Daniel Borkmann wrote: > > tools: Add ethtool.h header to tooling infra > > Could you follow up to remove this header? > Having to keep multiple headers in sync is annoying, and using > 'make headers' or including in-tree headers directly is not rocket > science. Just because I am curious, what was the reason/history behind the tools/include directory to start with? Most headers seem to be copies there. Thanks: Magnus
On Tue, 30 Apr 2024 10:16:33 +0200 Magnus Karlsson wrote: > > Could you follow up to remove this header? > > Having to keep multiple headers in sync is annoying, and using > > 'make headers' or including in-tree headers directly is not rocket > > science. > > Just because I am curious, what was the reason/history behind the > tools/include directory to start with? Most headers seem to be copies > there. I think it started as folks copying a handful of headers for perf tool and snowballed from there. By the time I pulled this the copy of ethtool.h was already out of date. So is if_xdp.h, BTW, as I am reminded every time I built networking selftests.