diff mbox series

[RFC,v1,3/5] dt-bindings: net: mediatek,net: add reset-cells

Message ID 20240505164549.65644-4-linux@fw-web.de (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series Add Bananapi R3 Mini | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Frank Wunderlich May 5, 2024, 4:45 p.m. UTC 
From: Frank Wunderlich <frank-w@public-files.de>

Add missing binding for property used in mt7986a.dtsi.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 Documentation/devicetree/bindings/net/mediatek,net.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski May 6, 2024, 8:19 a.m. UTC | #1 
On 05/05/2024 18:45, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add missing binding for property used in mt7986a.dtsi.
> 

Again, no, it is not missing, if the device is not reset controller.

Provide explanation why this is suitable in the binding. IOW, why DTS is
right, but binding is wrong.

Best regards,
Krzysztof
Rob Herring (Arm) May 7, 2024, 7:37 p.m. UTC | #2 
On Sun, May 05, 2024 at 06:45:47PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add missing binding for property used in mt7986a.dtsi.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  Documentation/devicetree/bindings/net/mediatek,net.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> index e74502a0afe8..5214927c0fe8 100644
> --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> @@ -101,6 +101,9 @@ properties:
>    "#address-cells":
>      const: 1
>  
> +  "#reset-cells":
> +    const: 1

Also fixed already.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index e74502a0afe8..5214927c0fe8 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
@@ -101,6 +101,9 @@  properties:
   "#address-cells":
     const: 1
 
+  "#reset-cells":
+    const: 1
+
   "#size-cells":
     const: 0