| Message ID | 20240506235251.3968262-2-pablo@netfilter.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 353f5ffbc63b532aa0c92a7635e84bd53d04644e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v3,01/12] gtp: remove useless initialization | expand |
On Tue, May 07, 2024 at 01:52:40AM +0200, Pablo Neira Ayuso wrote: > Update b20dc3c68458 ("gtp: Allow to create GTP device without FDs") to > remove useless initialization to NULL, sockets are initialized to > non-NULL just a few lines of code after this. > > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This series was applied to netdev/net-next.git (main) by Pablo Neira Ayuso <pablo@netfilter.org>: On Tue, 7 May 2024 01:52:40 +0200 you wrote: > Update b20dc3c68458 ("gtp: Allow to create GTP device without FDs") to > remove useless initialization to NULL, sockets are initialized to > non-NULL just a few lines of code after this. > > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> > --- > drivers/net/gtp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [net-next,v3,01/12] gtp: remove useless initialization https://git.kernel.org/netdev/net-next/c/353f5ffbc63b - [net-next,v3,02/12] gtp: properly parse extension headers https://git.kernel.org/netdev/net-next/c/b6fc0956ac53 - [net-next,v3,03/12] gtp: prepare for IPv6 support https://git.kernel.org/netdev/net-next/c/750771d0ca76 - [net-next,v3,04/12] gtp: add IPv6 support https://git.kernel.org/netdev/net-next/c/999cb275c807 - [net-next,v3,05/12] gtp: use IPv6 address /64 prefix for UE/MS https://git.kernel.org/netdev/net-next/c/c6461ec97b25 - [net-next,v3,06/12] gtp: pass up link local traffic to userspace socket https://git.kernel.org/netdev/net-next/c/e4f88f7381fa - [net-next,v3,07/12] gtp: move debugging to skbuff build helper function https://git.kernel.org/netdev/net-next/c/e075880459a8 - [net-next,v3,08/12] gtp: remove IPv4 and IPv6 header from context object https://git.kernel.org/netdev/net-next/c/559101a70784 - [net-next,v3,09/12] gtp: add helper function to build GTP packets from an IPv4 packet https://git.kernel.org/netdev/net-next/c/b77732f05ebb - [net-next,v3,10/12] gtp: add helper function to build GTP packets from an IPv6 packet https://git.kernel.org/netdev/net-next/c/045a7c15e791 - [net-next,v3,11/12] gtp: support for IPv4-in-IPv6-GTP and IPv6-in-IPv4-GTP https://git.kernel.org/netdev/net-next/c/e30ea48b5e7e - [net-next,v3,12/12] gtp: identify tunnel via GTP device + GTP version + TEID + family https://git.kernel.org/netdev/net-next/c/c75fc0b9e5be You are awesome, thank you!
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index e62d6cbdf9bc..dffb99a97e0f 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -1009,8 +1009,8 @@ static struct sock *gtp_create_sock(int type, struct gtp_dev *gtp) static int gtp_create_sockets(struct gtp_dev *gtp, struct nlattr *data[]) { - struct sock *sk1u = NULL; - struct sock *sk0 = NULL; + struct sock *sk1u; + struct sock *sk0; sk0 = gtp_create_sock(UDP_ENCAP_GTP0, gtp); if (IS_ERR(sk0))
Update b20dc3c68458 ("gtp: Allow to create GTP device without FDs") to remove useless initialization to NULL, sockets are initialized to non-NULL just a few lines of code after this. Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> --- drivers/net/gtp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)