diff mbox series

[net-next] ax25: Remove superfuous "return" from ax25_ds_set_timer

Message ID 20240507-jag-fix_void_ret_ax25-v1-1-507fb246f192@samsung.com (mailing list archive)
State Accepted
Commit 1d3985ed0dd3de7ee152ede633fe859806c38595
Delegated to: Netdev Maintainers
Headers show
Series [net-next] ax25: Remove superfuous "return" from ax25_ds_set_timer | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 927 this patch: 927
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 937 this patch: 937
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 938 this patch: 938
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-05-08--03-00 (tests: 1005)

Commit Message

Joel Granados via B4 Relay May 7, 2024, 8:40 a.m. UTC 
From: Joel Granados <j.granados@samsung.com>

Remove the explicit call to "return" in the void ax25_ds_set_timer
function that was introduced in 78a7b5dbc060 ("ax.25: x.25: Remove the
now superfluous sentinel elements from ctl_table array").

Signed-off-by: Joel Granados <j.granados@samsung.com>
---
I did not include a "Fixes:" tag as this (IMO) should not be backported
into a stable kernel. I'm assuming that net-next is going to be merged
into mainline as is and therefore I linked to a specific commit ID (get
back to me if I should do something different)

This comes after a review from Dave Carpenter [1] to an already accepted
patchset [2]

[1] https://lore.kernel.org/all/20240501-jag-sysctl_remset_net-v6-8-370b702b6b4a@samsung.com
[2] https://patchwork.kernel.org/project/netdevbpf/patch/20240501-jag-sysctl_remset_net-v6-1-370b702b6b4a@samsung.com/ 
---
 net/ax25/ax25_ds_timer.c | 1 -
 1 file changed, 1 deletion(-)


---
base-commit: 179a6f5df8dab7d027aa73a302d8506c6533e463
change-id: 20240507-jag-fix_void_ret_ax25-c78105dcdf79

Best regards,

Comments

patchwork-bot+netdevbpf@kernel.org May 8, 2024, 11:30 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Tue, 07 May 2024 10:40:39 +0200 you wrote:
> From: Joel Granados <j.granados@samsung.com>
> 
> Remove the explicit call to "return" in the void ax25_ds_set_timer
> function that was introduced in 78a7b5dbc060 ("ax.25: x.25: Remove the
> now superfluous sentinel elements from ctl_table array").
> 
> Signed-off-by: Joel Granados <j.granados@samsung.com>
> 
> [...]

Here is the summary with links:
  - [net-next] ax25: Remove superfuous "return" from ax25_ds_set_timer
    https://git.kernel.org/netdev/net-next/c/1d3985ed0dd3

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/ax25/ax25_ds_timer.c b/net/ax25/ax25_ds_timer.c
index c50a58d9e368..c4f8adbf8144 100644
--- a/net/ax25/ax25_ds_timer.c
+++ b/net/ax25/ax25_ds_timer.c
@@ -55,7 +55,6 @@  void ax25_ds_set_timer(ax25_dev *ax25_dev)
 	ax25_dev->dama.slave_timeout =
 		msecs_to_jiffies(ax25_dev->values[AX25_VALUES_DS_TIMEOUT]) / 10;
 	mod_timer(&ax25_dev->dama.slave_timer, jiffies + HZ);
-	return;
 }
 
 /*