| Message ID | 20240507113033.1732534-1-idosch@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9a169c267e946b0f47f67e8ccc70134708ccf3d4 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] selftests: test_bridge_neigh_suppress.sh: Fix failures due to duplicate MAC | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 7 May 2024 14:30:33 +0300 you wrote: > When creating the topology for the test, three veth pairs are created in > the initial network namespace before being moved to one of the network > namespaces created by the test. > > On systems where systemd-udev uses MACAddressPolicy=persistent (default > since systemd version 242), this will result in some net devices having > the same MAC address since they were created with the same name in the > initial network namespace. In turn, this leads to arping / ndisc6 > failing since packets are dropped by the bridge's loopback filter. > > [...] Here is the summary with links: - [net] selftests: test_bridge_neigh_suppress.sh: Fix failures due to duplicate MAC https://git.kernel.org/netdev/net/c/9a169c267e94 You are awesome, thank you!
diff --git a/tools/testing/selftests/net/test_bridge_neigh_suppress.sh b/tools/testing/selftests/net/test_bridge_neigh_suppress.sh index 8533393a4f18..02b986c9c247 100755 --- a/tools/testing/selftests/net/test_bridge_neigh_suppress.sh +++ b/tools/testing/selftests/net/test_bridge_neigh_suppress.sh @@ -154,17 +154,9 @@ setup_topo() setup_topo_ns $ns done - ip link add name veth0 type veth peer name veth1 - ip link set dev veth0 netns $h1 name eth0 - ip link set dev veth1 netns $sw1 name swp1 - - ip link add name veth0 type veth peer name veth1 - ip link set dev veth0 netns $sw1 name veth0 - ip link set dev veth1 netns $sw2 name veth0 - - ip link add name veth0 type veth peer name veth1 - ip link set dev veth0 netns $h2 name eth0 - ip link set dev veth1 netns $sw2 name swp1 + ip -n $h1 link add name eth0 type veth peer name swp1 netns $sw1 + ip -n $sw1 link add name veth0 type veth peer name veth0 netns $sw2 + ip -n $h2 link add name eth0 type veth peer name swp1 netns $sw2 } setup_host_common()
When creating the topology for the test, three veth pairs are created in the initial network namespace before being moved to one of the network namespaces created by the test. On systems where systemd-udev uses MACAddressPolicy=persistent (default since systemd version 242), this will result in some net devices having the same MAC address since they were created with the same name in the initial network namespace. In turn, this leads to arping / ndisc6 failing since packets are dropped by the bridge's loopback filter. Fix by creating each net device in the correct network namespace instead of moving it there from the initial network namespace. Reported-by: Jakub Kicinski <kuba@kernel.org> Closes: https://lore.kernel.org/netdev/20240426074015.251854d4@kernel.org/ Fixes: 7648ac72dcd7 ("selftests: net: Add bridge neighbor suppression test") Signed-off-by: Ido Schimmel <idosch@nvidia.com> --- .../selftests/net/test_bridge_neigh_suppress.sh | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)