| Message ID | 20240509151833.12579-1-vadim.fedorenko@linux.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 38155539a16ebb79dbb7a2e058138d70be68d245 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] bnxt_en: silence clang build warning | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net |
| netdev/apply | fail | Patch does not apply to net-0 |
On Thu, May 9, 2024 at 8:16 AM Vadim Fedorenko <vadim.fedorenko@linux.dev> wrote: > > Clang build brings a warning: > > ../drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c:133:12: warning: > comparison of distinct pointer types ('typeof (tmo_us) *' (aka 'unsigned > int *') and 'typeof (65535) *' (aka 'int *')) > [-Wcompare-distinct-pointer-types] > 133 | tmo_us = min(tmo_us, BNXT_PTP_QTS_MAX_TMO_US); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Fix it by specifying proper type for BNXT_PTP_QTS_MAX_TMO_US. > > Fixes: 7de3c2218eed ("bnxt_en: Add a timeout parameter to bnxt_hwrm_port_ts_query()") > Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev> Thanks. Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 9 May 2024 15:18:33 +0000 you wrote: > Clang build brings a warning: > > ../drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c:133:12: warning: > comparison of distinct pointer types ('typeof (tmo_us) *' (aka 'unsigned > int *') and 'typeof (65535) *' (aka 'int *')) > [-Wcompare-distinct-pointer-types] > 133 | tmo_us = min(tmo_us, BNXT_PTP_QTS_MAX_TMO_US); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > [...] Here is the summary with links: - [net] bnxt_en: silence clang build warning https://git.kernel.org/netdev/net-next/c/38155539a16e You are awesome, thank you!
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.h index 6a2bba3f9e2d..2c3415c8fc03 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.h @@ -24,7 +24,7 @@ #define BNXT_PTP_DFLT_TX_TMO 1000 /* ms */ #define BNXT_PTP_QTS_TIMEOUT 1000 -#define BNXT_PTP_QTS_MAX_TMO_US 65535 +#define BNXT_PTP_QTS_MAX_TMO_US 65535U #define BNXT_PTP_QTS_TX_ENABLES (PORT_TS_QUERY_REQ_ENABLES_PTP_SEQ_ID | \ PORT_TS_QUERY_REQ_ENABLES_TS_REQ_TIMEOUT | \ PORT_TS_QUERY_REQ_ENABLES_PTP_HDR_OFFSET)
Clang build brings a warning: ../drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c:133:12: warning: comparison of distinct pointer types ('typeof (tmo_us) *' (aka 'unsigned int *') and 'typeof (65535) *' (aka 'int *')) [-Wcompare-distinct-pointer-types] 133 | tmo_us = min(tmo_us, BNXT_PTP_QTS_MAX_TMO_US); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fix it by specifying proper type for BNXT_PTP_QTS_MAX_TMO_US. Fixes: 7de3c2218eed ("bnxt_en: Add a timeout parameter to bnxt_hwrm_port_ts_query()") Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)